incorporating code review comments.

lokeshrangineni · lokeshrangineni · commit 77fc4c37142a · 2024-10-25T10:00:52.000-04:00
Signed-off-by: lrangine &lt;19699092+lokeshrangineni@users.noreply.github.com&gt;
diff --git a/docs/reference/feature-servers/python-feature-server.md b/docs/reference/feature-servers/python-feature-server.md
@@ -200,10 +200,10 @@ requests.post(
     data=json.dumps(push_data))
 ```
 
-## Starting feature server in SSL mode
+## Starting the feature server in SSL mode
 
 ### Obtaining a self-signed SSL certificate and key
-In development mode we can generate self-signed certificate for testing purpose. In actual production environment it is always recommended to get it from the popular SSL certificate providers.
+In development mode we can generate a self-signed certificate for testing. In an actual production environment it is always recommended to get it from an SSL certificate provider.
 
 ```shell
 openssl req -x509 -newkey rsa:2048 -keyout key.pem -out cert.pem -days 365 -nodes
@@ -213,7 +213,7 @@ The above command will generate two files
 * `key.pem` : certificate private key
 * `cert.pem`: certificate public key
 
-### Starting Online Server in SSL Mode
+### Starting the Online Server in SSL Mode
 To start the feature server in SSL mode, you need to provide the private and public keys using the `--ssl-key-path` and `--ssl-cert-path` arguments with the `feast serve` command.
 
 ```shell
diff --git a/docs/reference/online-stores/remote.md b/docs/reference/online-stores/remote.md
@@ -23,7 +23,7 @@ auth:
 ```
 {% endcode %}
 
-`ssl_cert_path` is optional configuration. Path to the public certificate path in case if the online server starts in SSL mode. This may be needed especially if online server started with a self-signed certificate, typically this file ends with .crt, .cer, or .pem.
+`ssl_cert_path` is an optional configuration to the public certificate path when the online server starts in SSL mode. This may be needed if the online server is started with a self-signed certificate, typically this file ends with `*.crt`, `*.cer`, or `*.pem`.
 
 ## How to configure Authentication and Authorization
 Please refer the [page](./../../../docs/getting-started/concepts/permission.md) for more details on how to configure authentication and authorization.
diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -951,7 +951,7 @@ def serve_command(
     """Start a feature server locally on a given port."""
     if (ssl_key_path and not ssl_cert_path) or (not ssl_key_path and ssl_cert_path):
         raise click.BadParameter(
-            "Please send ssl-cert-path and ssl-key-path args to start feature server in SSL mode."
+            "Please configure ssl-cert-path and ssl-key-path args to start the feature server in SSL mode."
         )
 
     store = create_feature_store(ctx)
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -367,7 +367,6 @@ def start_server(
 
     if sys.platform != "win32":
         options = {
-            "store": store,
             "bind": f"{host}:{port}",
             "accesslog": None if no_access_log else "-",
             "workers": workers,
@@ -379,7 +378,7 @@ def start_server(
         if ssl_key_path and ssl_cert_path:
             options["keyfile"] = ssl_key_path
             options["certfile"] = ssl_cert_path
-        FeastServeApplication(**options).run()
+        FeastServeApplication(store=store, **options).run()
     else:
         import uvicorn
 
diff --git a/sdk/python/feast/infra/online_stores/remote.py b/sdk/python/feast/infra/online_stores/remote.py
@@ -42,7 +42,7 @@ class RemoteOnlineStoreConfig(FeastConfigBaseModel):
     If type is 'remote', then this is a URL for registry server """
 
     ssl_cert_path: StrictStr = ""
-    """ str: Path to the public certificate in case if the online server starts in SSL mode. This may be needed especially if online server started with a self-signed certificate, typically this file ends with .crt, .cer, or .pem.
+    """ str: Path to the public certificate when the online server starts in SSL mode. This may be needed if the online server started with a self-signed certificate, typically this file ends with `*.crt`, `*.cer`, or `*.pem`.
     If type is 'remote', then this configuration is needed to connect to remote online server in SSL mode. """
 
 
diff --git a/sdk/python/tests/integration/online_store/test_remote_online_store.py b/sdk/python/tests/integration/online_store/test_remote_online_store.py
@@ -228,36 +228,21 @@ def _overwrite_remote_client_feature_store_yaml(
     ssl_cert_path: str = "",
 ):
     repo_config = os.path.join(repo_path, "feature_store.yaml")
-    with open(repo_config, "w") as repo_config:
-        if ssl_cert_path:
-            repo_config.write(
-                dedent(
-                    f"""
-                project: {PROJECT_NAME}
-                registry: {registry_path}
-                provider: local
-                online_store:
-                    path: {feature_server_url}
-                    type: remote
-                    ssl_cert_path: {ssl_cert_path}
-                entity_key_serialization_version: 2
-                """
-                )
-                + auth_config
-            )
+    config_content = dedent(
+        f"""
+    project: {PROJECT_NAME}
+    registry: {registry_path}
+    provider: local
+    online_store:
+        path: {feature_server_url}
+        type: remote
+    """
+    )
 
-        else:
-            repo_config.write(
-                dedent(
-                    f"""
-                project: {PROJECT_NAME}
-                registry: {registry_path}
-                provider: local
-                online_store:
-                    path: {feature_server_url}
-                    type: remote
-                entity_key_serialization_version: 2
-                """
-                )
-                + auth_config
-            )
+    if ssl_cert_path:
+        config_content += f"    ssl_cert_path: {ssl_cert_path}\n"
+
+    config_content += "    entity_key_serialization_version: 2\n" + auth_config
+
+    with open(repo_config, "w") as repo_config_file:
+        repo_config_file.write(config_content)

Original file line number	Diff line number	Diff line change
`@@ -951,7 +951,7 @@ def serve_command(`
`951`	`951`	`"""Start a feature server locally on a given port."""`
`952`	`952`	`if (ssl_key_path and not ssl_cert_path) or (not ssl_key_path and ssl_cert_path):`
`953`	`953`	`raise click.BadParameter(`
`954`		`- "Please send ssl-cert-path and ssl-key-path args to start feature server in SSL mode."`
	`954`	`+ "Please configure ssl-cert-path and ssl-key-path args to start the feature server in SSL mode."`
`955`	`955`	`)`
`956`	`956`
`957`	`957`	`store = create_feature_store(ctx)`