add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it)

astronautas · astronautas · commit 776c545b5876 · 2025-10-15T15:26:29.000+03:00
Signed-off-by: lukas.valatka &lt;lukas.valatka@cast.ai&gt;
diff --git a/sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse.py b/sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse.py
@@ -191,6 +191,43 @@ def pull_latest_from_table_or_query(
             on_demand_feature_views=None,
         )
 
+    @staticmethod
+    def pull_all_from_table_or_query(
+        config: RepoConfig,
+        data_source: DataSource,
+        join_key_columns: List[str],
+        feature_name_columns: List[str],
+        timestamp_field: str,
+        created_timestamp_column: Optional[str] = None,
+        start_date: Optional[datetime] = None,
+        end_date: Optional[datetime] = None,
+    ) -> RetrievalJob:
+        assert isinstance(config.offline_store, ClickhouseOfflineStoreConfig)
+        assert isinstance(data_source, ClickhouseSource)
+
+        from_expression = data_source.get_table_query_string()
+
+        timestamp_fields = [timestamp_field]
+
+        if created_timestamp_column:
+            timestamp_fields.append(created_timestamp_column)
+
+        field_string = ", ".join(
+            join_key_columns + feature_name_columns + timestamp_fields
+        )
+
+        query = f"""
+            SELECT {field_string}
+            FROM {from_expression}
+            WHERE {timestamp_field} BETWEEN parseDateTimeBestEffort('{start_date}') AND parseDateTimeBestEffort('{end_date}')
+        """
+
+        return ClickhouseRetrievalJob(
+            query=query,
+            config=config,
+            full_feature_names=False,
+        )
+
 
 class ClickhouseRetrievalJob(PostgreSQLRetrievalJob):
     def _to_df_internal(self, timeout: Optional[int] = None) -> pd.DataFrame:
diff --git a/sdk/python/tests/integration/registration/test_universal_types.py b/sdk/python/tests/integration/registration/test_universal_types.py
@@ -343,7 +343,6 @@ def offline_types_test_fixtures(request, environment):
     if (
         environment.data_source_creator.__class__.__name__
         == "ClickhouseDataSourceCreator"
-        and config.feature_dtype in {"float", "datetime", "bool"}
         and config.feature_is_list
         and not config.has_empty_list
     ):
