Skip to content

Commit 7565fe6

Browse files
author
zhilingc
committed
Change proto format to be google-compliant
1 parent a03db75 commit 7565fe6

File tree

8 files changed

+41
-41
lines changed

8 files changed

+41
-41
lines changed

‎protos/feast/core/CoreService.proto‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ service CoreService {
4444
// Retrieves details for all versions of a specific feature set
4545
message GetFeatureSetsRequest {
4646
message Filter {
47-
string featureSetName = 1;
48-
string featureSetVersion = 2;
47+
string feature_set_name = 1;
48+
string feature_set_version = 2;
4949
}
5050

5151
Filter filter = 1;
5252
}
5353

5454
message GetFeatureSetsResponse {
55-
repeated feast.core.FeatureSetSpec featureSets = 1;
55+
repeated feast.core.FeatureSetSpec feature_sets = 1;
5656
}
5757

5858
message GetStoresRequest {
@@ -69,7 +69,7 @@ message GetStoresResponse {
6969

7070
message ApplyFeatureSetRequest {
7171
// Feature set version and source will be ignored
72-
feast.core.FeatureSetSpec featureSet = 1;
72+
feast.core.FeatureSetSpec feature_set = 1;
7373
}
7474

7575
message ApplyFeatureSetResponse {
@@ -85,7 +85,7 @@ message ApplyFeatureSetResponse {
8585
}
8686

8787
// Feature set response has been enriched with version and source information
88-
feast.core.FeatureSetSpec featureSet = 1;
88+
feast.core.FeatureSetSpec feature_set = 1;
8989
Status status = 2;
9090
}
9191

‎protos/feast/core/FeatureSet.proto‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ message EntitySpec {
5454
string name = 1;
5555

5656
// Value type of the feature.
57-
feast.types.ValueType.Enum valueType = 2;
57+
feast.types.ValueType.Enum value_type = 2;
5858
}
5959

6060
message FeatureSpec {
6161
// Name of the feature.
6262
string name = 1;
6363

6464
// Value type of the feature.
65-
feast.types.ValueType.Enum valueType = 2;
65+
feast.types.ValueType.Enum value_type = 2;
6666
}

‎protos/feast/core/Store.proto‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ message Store {
3636
}
3737

3838
message BigQueryConfig {
39-
string projectId = 1;
40-
string datasetId = 2;
39+
string project_id = 1;
40+
string dataset_id = 2;
4141
}
4242

4343
message CassandraConfig {
@@ -68,8 +68,8 @@ message Store {
6868

6969
// Configuration to connect to the store. Required.
7070
oneof config {
71-
RedisConfig redisConfig = 11;
72-
BigQueryConfig bigqueryConfig = 12;
73-
CassandraConfig cassandraConfig = 13;
71+
RedisConfig redis_config = 11;
72+
BigQueryConfig bigquery_config = 12;
73+
CassandraConfig cassandra_config = 13;
7474
}
7575
}

‎protos/feast/serving/ServingService.proto‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ message GetFeaturesRequest {
6565
string version = 2;
6666

6767
// Features that should be retrieved from this feature set
68-
repeated string featureNames = 3;
68+
repeated string feature_names = 3;
6969
}
7070

7171
message EntityDataSet {
@@ -75,20 +75,20 @@ message GetFeaturesRequest {
7575
repeated string fieldNames = 1;
7676

7777
// List of timestamp and entity id values
78-
repeated EntityDataSetRow entityDataSetRows = 2;
78+
repeated EntityDataSetRow entity_data_set_rows = 2;
7979
}
8080

8181
message EntityDataSetRow {
8282
// List of timestamp and entity id values. The first value is always a Unix timestamp at
8383
// UTC+0. All subsequent values are entity ids in order of the entityNames list in the
8484
// wrapping message
85-
repeated feast.types.Value Value = 1;
85+
repeated feast.types.Value value = 1;
8686
}
8787
}
8888

8989
message GetOnlineFeaturesResponse {
9090
// A FeatureDataSet is returned for each feature set in the incoming request
91-
repeated FeatureDataSet featureDataSets = 2;
91+
repeated FeatureDataSet feature_data_sets = 2;
9292

9393
// The FeatureDataSet contains information about the Feature Set in the incoming request,
9494
// as well as feature data that can be joined to the incoming EntityDataSet. The row count
@@ -105,7 +105,7 @@ message GetOnlineFeaturesResponse {
105105
// are the original event timestamps from when that row was written to the backing store.
106106
// When these FeatureRows are joined to the EntityDataSetRows, the FeatureRow timestamps
107107
// will be dropped in favour of the EntityDataSetRow timestamp.
108-
repeated feast.types.FeatureRow featureRows = 3;
108+
repeated feast.types.FeatureRow feature_rows = 3;
109109
}
110110
}
111111

@@ -161,11 +161,11 @@ message BatchFeaturesJob {
161161
message GetUploadUrlRequest {
162162

163163
// Job Id associated to this request
164-
string jobUUID = 1;
164+
string job_UUID = 1;
165165

166166
// Type of file that will be uploaded. Feast Serving needs to maintain this type in order to
167167
// interpret the entity dataset when loading it into the backing store
168-
FileType fileType = 2;
168+
FileType file_type = 2;
169169

170170
enum FileType {
171171
CSV = 0;
@@ -178,7 +178,7 @@ message BatchFeaturesJob {
178178
// Url specifies the full signed URL where a client can make a request to upload file to GCS
179179
string url = 1;
180180

181-
HttpMethod httpMethod = 2;
181+
HttpMethod http_method = 2;
182182
enum HttpMethod {
183183
PUT = 0;
184184
}
@@ -189,7 +189,7 @@ message BatchFeaturesJob {
189189

190190
// Notifies Feast Serving that the specific upload request has been completed for a job Id
191191
message SetUploadCompleteRequest {
192-
string jobUUID = 1;
192+
string job_UUID = 1;
193193
}
194194

195195
// Notifies caller that the staged file has been found and will be ingested into the backing store

‎protos/feast/storage/Redis.proto‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ message RedisKey {
3030
// (for when redis is clustered).
3131

3232
// FeatureSet this row belongs to, this is defined as featureSetName:version.
33-
string featureSet = 2;
33+
string feature_set = 2;
3434

3535
// List of fields containing entity names and their respective values
3636
// contained within this feature row.

‎protos/feast/types/FeatureRow.proto‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ message FeatureRow {
3333
// Timestamp of the feature row. While the actual definition of this timestamp may vary
3434
// depending on the upstream feature creation pipelines, this is the timestamp that Feast
3535
// will use to perform joins, determine latest values, and coalesce rows.
36-
google.protobuf.Timestamp eventTimestamp = 3;
36+
google.protobuf.Timestamp event_timestamp = 3;
3737

3838
// Complete reference to the featureSet this featureRow belongs to, in the form of
3939
// featureSetName:version. This value will be used by the feast ingestion job to filter
4040
// rows, and write the values to the correct tables.
41-
string featureSet = 6;
41+
string feature_set = 6;
4242
}

‎protos/feast/types/FeatureRowExtended.proto‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ message Error {
2929
string cause = 1; // exception class name
3030
string transform = 2; // name of transform where the error occurred
3131
string message = 3;
32-
string stackTrace = 4;
32+
string stack_trace = 4;
3333
}
3434

3535
message Attempt {
@@ -39,6 +39,6 @@ message Attempt {
3939

4040
message FeatureRowExtended {
4141
FeatureRow row = 1;
42-
Attempt lastAttempt = 2;
43-
google.protobuf.Timestamp firstSeen = 3;
42+
Attempt last_attempt = 2;
43+
google.protobuf.Timestamp first_seen = 3;
4444
}

‎protos/feast/types/Value.proto‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,20 @@ message Value {
4848
// ValueType is referenced by the metadata types, FeatureInfo and EntityInfo.
4949
// The enum values do not have to match the oneof val field ids, but they should.
5050
oneof val {
51-
bytes bytesVal = 1;
52-
string stringVal = 2;
53-
int32 int32Val = 3;
54-
int64 int64Val = 4;
55-
double doubleVal = 5;
56-
float floatVal = 6;
57-
bool boolVal = 7;
58-
BytesList bytesListVal = 11;
59-
StringList stringListVal = 12;
60-
Int32List int32ListVal = 13;
61-
Int64List int64ListVal = 14;
62-
DoubleList doubleListVal = 15;
63-
FloatList floatListVal = 16;
64-
BoolList boolListVal = 17;
51+
bytes bytes_val = 1;
52+
string string_val = 2;
53+
int32 int32_val = 3;
54+
int64 int64_val = 4;
55+
double double_val = 5;
56+
float float_val = 6;
57+
bool bool_val = 7;
58+
BytesList bytes_list_val = 11;
59+
StringList string_list_val = 12;
60+
Int32List int32_list_val = 13;
61+
Int64List int64_list_val = 14;
62+
DoubleList double_list_val = 15;
63+
FloatList float_list_val = 16;
64+
BoolList bool_list_val = 17;
6565
}
6666
}
6767

0 commit comments

Comments
 (0)