Skip to content

Commit 74f6e96

Browse files
author
zhilingc
committed
Clean up job options
1 parent 2823d71 commit 74f6e96

2 files changed

Lines changed: 1 addition & 30 deletions

File tree

core/src/main/java/feast/core/job/direct/DirectRunnerJobManager.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ private ImportOptions getPipelineOptions(List<FeatureSetSpec> featureSetSpecs,
9898
pipelineOptions.setFeatureSetSpecJson(featureSetsJson);
9999
pipelineOptions.setStoreJson(Collections.singletonList(printer.print(sink)));
100100
pipelineOptions.setRunner(DirectRunner.class);
101+
pipelineOptions.setProject(""); // set to default value to satisfy validation
101102
if (metrics.isEnabled()) {
102103
pipelineOptions.setMetricsExporterType(metrics.getType());
103104
if (metrics.getType().equals("prometheus")) {

ingestion/src/main/java/feast/ingestion/options/ImportOptions.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -84,34 +84,4 @@ public interface ImportOptions extends PipelineOptions, DataflowPipelineOptions,
8484

8585
void setPrometheusExporterAddress(String prometheusExporterAddress);
8686

87-
@Description("Limit of rows to sample and output for debugging")
88-
@Default.Integer(0)
89-
int getSampleLimit();
90-
91-
void setSampleLimit(int value);
92-
93-
@Description(
94-
"Enable coalesce rows, merges feature rows within a time window to output only the latest value")
95-
@Default.Boolean(false)
96-
boolean isCoalesceRowsEnabled();
97-
98-
void setCoalesceRowsEnabled(boolean value);
99-
100-
@Description("Delay in seconds to wait for newer values to coalesce on key before emitting")
101-
@Default.Integer(10)
102-
int getCoalesceRowsDelaySeconds();
103-
104-
void setCoalesceRowsDelaySeconds(int value);
105-
106-
@Description("Time in seconds to retain feature rows to merge with newer records")
107-
@Default.Integer(30)
108-
int getCoalesceRowsTimeoutSeconds();
109-
110-
void setCoalesceRowsTimeoutSeconds(int value);
111-
112-
@Description("If dry run is set, execute up to feature row validation")
113-
@Default.Boolean(false)
114-
Boolean isDryRun();
115-
116-
void setDryRun(Boolean value);
11787
}

0 commit comments

Comments
 (0)