Skip to content

Commit 7446c20

Browse files
committed
metadata methods
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 4618566 commit 7446c20

2 files changed

Lines changed: 29 additions & 10 deletions

File tree

sdk/python/feast/infra/registry_stores/sql.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@
140140

141141

142142
class SqlRegistry(BaseRegistry):
143-
144143
def __init__(
145144
self, registry_config: Optional[RegistryConfig], repo_path: Optional[Path]
146145
):
@@ -475,7 +474,12 @@ def update_infra(self, infra: Infra, project: str, commit: bool = True):
475474
def get_infra(self, project: str, allow_cache: bool = False) -> Infra:
476475
pass
477476

478-
def apply_user_metadata(self, project: str, feature_view: BaseFeatureView, metadata_bytes: Optional[bytes]):
477+
def apply_user_metadata(
478+
self,
479+
project: str,
480+
feature_view: BaseFeatureView,
481+
metadata_bytes: Optional[bytes],
482+
):
479483
if isinstance(feature_view, FeatureView):
480484
table = feature_views
481485
elif isinstance(feature_view, OnDemandFeatureView):
@@ -500,14 +504,16 @@ def apply_user_metadata(self, project: str, feature_view: BaseFeatureView, metad
500504
}
501505
update_stmt = (
502506
update(table)
503-
.where(getattr(table.c, "feature_view_name") == name)
504-
.values(values,)
507+
.where(getattr(table.c, "feature_view_name") == name)
508+
.values(values,)
505509
)
506510
conn.execute(update_stmt)
507511
else:
508512
raise FeatureViewNotFoundException(feature_view.name, project=project)
509513

510-
def get_user_metadata(self, project: str, feature_view: BaseFeatureView) -> Optional[bytes]:
514+
def get_user_metadata(
515+
self, project: str, feature_view: BaseFeatureView
516+
) -> Optional[bytes]:
511517
if isinstance(feature_view, FeatureView):
512518
table = feature_views
513519
elif isinstance(feature_view, OnDemandFeatureView):
@@ -583,7 +589,6 @@ def _apply_object(
583589
insert_stmt = insert(table).values(values,)
584590
conn.execute(insert_stmt)
585591

586-
587592
def _delete_object(self, table, name, project, id_field_name, not_found_exception):
588593
with self.engine.connect() as conn:
589594
stmt = delete(table).where(getattr(table.c, id_field_name) == name)

sdk/python/feast/registry.py

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -632,11 +632,18 @@ def get_infra(self, project: str, allow_cache: bool = False) -> Infra:
632632
"""
633633

634634
@abstractmethod
635-
def apply_user_metadata(self, project: str, feature_view: BaseFeatureView, metadata_bytes: Optional[bytes]):
635+
def apply_user_metadata(
636+
self,
637+
project: str,
638+
feature_view: BaseFeatureView,
639+
metadata_bytes: Optional[bytes],
640+
):
636641
...
637642

638643
@abstractmethod
639-
def get_user_metadata(self, project: str, feature_view: BaseFeatureView) -> Optional[bytes]:
644+
def get_user_metadata(
645+
self, project: str, feature_view: BaseFeatureView
646+
) -> Optional[bytes]:
640647
...
641648

642649
@abstractmethod
@@ -662,10 +669,17 @@ class Registry(BaseRegistry):
662669
Registry: A registry allows for the management and persistence of feature definitions and related metadata.
663670
"""
664671

665-
def apply_user_metadata(self, project: str, feature_view: BaseFeatureView, metadata_bytes: Optional[bytes]):
672+
def apply_user_metadata(
673+
self,
674+
project: str,
675+
feature_view: BaseFeatureView,
676+
metadata_bytes: Optional[bytes],
677+
):
666678
pass
667679

668-
def get_user_metadata(self, project: str, feature_view: BaseFeatureView) -> Optional[bytes]:
680+
def get_user_metadata(
681+
self, project: str, feature_view: BaseFeatureView
682+
) -> Optional[bytes]:
669683
pass
670684

671685
# The cached_registry_proto object is used for both reads and writes. In particular,

0 commit comments

Comments
 (0)