fix: Fix DataSource constructor to unbreak custom data sources (#2492)

achals · web-flow · commit 712653e91cc4 · 2022-04-05T10:48:23.000-07:00
* fix: Fix DataSource constructor to unbreak custom data sources

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;

* fix first party refernces to use kwargs only

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;

* remove force kwargs

Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/data_source.py b/sdk/python/feast/data_source.py
@@ -14,6 +14,7 @@
 
 
 import enum
+import warnings
 from abc import ABC, abstractmethod
 from typing import Any, Callable, Dict, Iterable, Optional, Tuple
 
@@ -179,14 +180,14 @@ class DataSource(ABC):
 
     def __init__(
         self,
-        name: str,
         event_timestamp_column: Optional[str] = None,
         created_timestamp_column: Optional[str] = None,
         field_mapping: Optional[Dict[str, str]] = None,
         date_partition_column: Optional[str] = None,
         description: Optional[str] = "",
         tags: Optional[Dict[str, str]] = None,
         owner: Optional[str] = "",
+        name: Optional[str] = None,
     ):
         """
         Creates a DataSource object.
@@ -205,7 +206,15 @@ def __init__(
             owner (optional): The owner of the data source, typically the email of the primary
                 maintainer.
         """
-        self.name = name
+        if not name:
+            warnings.warn(
+                (
+                    "Names for data sources need to be supplied. "
+                    "Data sources without names will no tbe supported after Feast 0.23."
+                ),
+                UserWarning,
+            )
+        self.name = name or ""
         self.event_timestamp_column = (
             event_timestamp_column if event_timestamp_column else ""
         )
@@ -340,14 +349,14 @@ def __init__(
         owner: Optional[str] = "",
     ):
         super().__init__(
-            name,
-            event_timestamp_column,
-            created_timestamp_column,
-            field_mapping,
-            date_partition_column,
+            event_timestamp_column=event_timestamp_column,
+            created_timestamp_column=created_timestamp_column,
+            field_mapping=field_mapping,
+            date_partition_column=date_partition_column,
             description=description,
             tags=tags,
             owner=owner,
+            name=name,
         )
         self.kafka_options = KafkaOptions(
             bootstrap_servers=bootstrap_servers,
@@ -438,7 +447,7 @@ def __init__(
         owner: Optional[str] = "",
     ):
         """Creates a RequestDataSource object."""
-        super().__init__(name, description=description, tags=tags, owner=owner)
+        super().__init__(name=name, description=description, tags=tags, owner=owner)
         self.schema = schema
 
     def validate(self, config: RepoConfig):
@@ -536,11 +545,11 @@ def __init__(
         owner: Optional[str] = "",
     ):
         super().__init__(
-            name,
-            event_timestamp_column,
-            created_timestamp_column,
-            field_mapping,
-            date_partition_column,
+            name=name,
+            event_timestamp_column=event_timestamp_column,
+            created_timestamp_column=created_timestamp_column,
+            field_mapping=field_mapping,
+            date_partition_column=date_partition_column,
             description=description,
             tags=tags,
             owner=owner,
@@ -620,7 +629,7 @@ def __init__(
             owner (optional): The owner of the data source, typically the email of the primary
                 maintainer.
         """
-        super().__init__(name, description=description, tags=tags, owner=owner)
+        super().__init__(name=name, description=description, tags=tags, owner=owner)
         self.schema = schema
         self.batch_source = batch_source
         if not self.batch_source:
diff --git a/sdk/python/feast/infra/offline_stores/bigquery_source.py b/sdk/python/feast/infra/offline_stores/bigquery_source.py
@@ -86,7 +86,7 @@ def __init__(
                 )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,
diff --git a/sdk/python/feast/infra/offline_stores/redshift_source.py b/sdk/python/feast/infra/offline_stores/redshift_source.py
@@ -80,7 +80,7 @@ def __init__(
             )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,
diff --git a/sdk/python/feast/infra/offline_stores/snowflake_source.py b/sdk/python/feast/infra/offline_stores/snowflake_source.py
@@ -88,7 +88,7 @@ def __init__(
             )
 
         super().__init__(
-            _name if _name else "",
+            name=_name if _name else "",
             event_timestamp_column=event_timestamp_column,
             created_timestamp_column=created_timestamp_column,
             field_mapping=field_mapping,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ def __init__(`
`86`	`86`	`)`
`87`	`87`
`88`	`88`	`super().__init__(`
`89`		`- _name if _name else "",`
	`89`	`+ name=_name if _name else "",`
`90`	`90`	`event_timestamp_column=event_timestamp_column,`
`91`	`91`	`created_timestamp_column=created_timestamp_column,`
`92`	`92`	`field_mapping=field_mapping,`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ def __init__(`
`80`	`80`	`)`
`81`	`81`
`82`	`82`	`super().__init__(`
`83`		`- _name if _name else "",`
	`83`	`+ name=_name if _name else "",`
`84`	`84`	`event_timestamp_column=event_timestamp_column,`
`85`	`85`	`created_timestamp_column=created_timestamp_column,`
`86`	`86`	`field_mapping=field_mapping,`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ def __init__(`
`88`	`88`	`)`
`89`	`89`
`90`	`90`	`super().__init__(`
`91`		`- _name if _name else "",`
	`91`	`+ name=_name if _name else "",`
`92`	`92`	`event_timestamp_column=event_timestamp_column,`
`93`	`93`	`created_timestamp_column=created_timestamp_column,`
`94`	`94`	`field_mapping=field_mapping,`