Make metrics import resilient when prometheus_client is unavailable

antznette1 · antznette1 · commit 6cd6eb76a81e · 2026-04-05T09:59:20.000+01:00
Signed-off-by: antznette1 &lt;ochiezeanthonette@gmail.com&gt;
diff --git a/sdk/python/feast/metrics.py b/sdk/python/feast/metrics.py
@@ -102,7 +102,33 @@ def _cleanup_multiprocess_dir():
 atexit.register(_cleanup_multiprocess_dir)
 
 # Now safe to import prometheus_client — it will detect the env var.
-from prometheus_client import Counter, Gauge, Histogram  # noqa: E402
+_prometheus_available = True
+try:
+    from prometheus_client import Counter, Gauge, Histogram  # noqa: E402
+except Exception:
+    _prometheus_available = False
+
+    class _NoOpMetric:
+        def labels(self, **kwargs):
+            return self
+
+        def inc(self, amount: float = 1):
+            return None
+
+        def observe(self, amount: float):
+            return None
+
+        def set(self, value: float):
+            return None
+
+    def Counter(*args, **kwargs):  # type: ignore
+        return _NoOpMetric()
+
+    def Gauge(*args, **kwargs):  # type: ignore
+        return _NoOpMetric()
+
+    def Histogram(*args, **kwargs):  # type: ignore
+        return _NoOpMetric()
 
 
 # ---------------------------------------------------------------------------
@@ -473,6 +499,12 @@ def start_metrics_server(
     """
     global _config
 
+    if not _prometheus_available:
+        logger.warning(
+            "Prometheus metrics are unavailable because prometheus_client could not be imported."
+        )
+        return
+
     if metrics_config is not None:
         _config = metrics_config
     else:
