Skip to content

Commit 6ac2e7d

Browse files
update test and fix bug to support skipping transformation on writes for ODFV
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
1 parent 3c90cdb commit 6ac2e7d

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

sdk/python/tests/unit/test_on_demand_python_transformation.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1107,17 +1107,16 @@ def python_stored_writes_feature_view(
11071107
"python_stored_writes_feature_view:string_constant",
11081108
],
11091109
).to_dict()
1110+
# note these are approximately correct by
11101111
assert online_odfv_python_response_no_transform == {
1111-
'driver_id': [1003],
1112-
'string_constant': [ODFV_UNTRANSFORMED_STRING_CONSTANT],
1113-
'counter': [10],
1114-
'conv_rate_plus_acc': [7],
1115-
'input_datetime': [current_datetime],
1116-
'current_datetime': [current_datetime]
1112+
"driver_id": [1003],
1113+
"counter": [10],
1114+
"conv_rate_plus_acc": [None],
1115+
"input_datetime": [current_datetime.replace(microsecond=0)],
1116+
"string_constant": [ODFV_UNTRANSFORMED_STRING_CONSTANT],
1117+
"current_datetime": [None],
11171118
}
11181119

1119-
1120-
11211120
def test_stored_writes_with_explode(self):
11221121
with tempfile.TemporaryDirectory() as data_dir:
11231122
self.store = FeatureStore(

0 commit comments

Comments
 (0)