Skip to content

Commit 6a33f46

Browse files
committed
remove macos
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 16e8944 commit 6a33f46

2 files changed

Lines changed: 22 additions & 6 deletions

File tree

.github/workflows/unit_tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ jobs:
3232
uses: actions/setup-go@v2
3333
with:
3434
go-version: 1.17.7
35-
- name: Install mysql on macOS
36-
if: startsWith(matrix.os, 'macOS')
37-
run: |
38-
brew install mysql
39-
PATH=$PATH:/usr/local/mysql/bin
4035
- name: Upgrade pip version
4136
run: |
4237
pip install --upgrade "pip>=22.1,<23"

sdk/python/tests/integration/registration/test_sql_registry.py

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414
import logging
15+
import sys
1516
from datetime import timedelta
1617

1718
import pandas as pd
@@ -98,6 +99,9 @@ def mysql_registry():
9899
container.stop()
99100

100101

102+
@pytest.mark.skipif(
103+
sys.platform == "darwin", reason="does not run on mac github actions"
104+
)
101105
@pytest.mark.parametrize(
102106
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
103107
)
@@ -137,6 +141,9 @@ def test_apply_entity_success(sql_registry):
137141
sql_registry.teardown()
138142

139143

144+
@pytest.mark.skipif(
145+
sys.platform == "darwin", reason="does not run on mac github actions"
146+
)
140147
@pytest.mark.integration
141148
@pytest.mark.parametrize(
142149
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
@@ -173,6 +180,9 @@ def test_apply_entity_integration(sql_registry):
173180
sql_registry.teardown()
174181

175182

183+
@pytest.mark.skipif(
184+
sys.platform == "darwin", reason="does not run on mac github actions"
185+
)
176186
@pytest.mark.parametrize(
177187
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
178188
)
@@ -244,6 +254,9 @@ def test_apply_feature_view_success(sql_registry):
244254
sql_registry.teardown()
245255

246256

257+
@pytest.mark.skipif(
258+
sys.platform == "darwin", reason="does not run on mac github actions"
259+
)
247260
@pytest.mark.parametrize(
248261
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
249262
)
@@ -314,7 +327,9 @@ def location_features_from_push(inputs: pd.DataFrame) -> pd.DataFrame:
314327
sql_registry.teardown()
315328

316329

317-
# TODO(kevjumba): remove this in feast 0.23 when deprecating
330+
@pytest.mark.skipif(
331+
sys.platform == "darwin", reason="does not run on mac github actions"
332+
)
318333
@pytest.mark.parametrize(
319334
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
320335
)
@@ -434,6 +449,9 @@ def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
434449
sql_registry.teardown()
435450

436451

452+
@pytest.mark.skipif(
453+
sys.platform == "darwin", reason="does not run on mac github actions"
454+
)
437455
@pytest.mark.integration
438456
@pytest.mark.parametrize(
439457
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],
@@ -506,6 +524,9 @@ def test_apply_feature_view_integration(sql_registry):
506524
sql_registry.teardown()
507525

508526

527+
@pytest.mark.skipif(
528+
sys.platform == "darwin", reason="does not run on mac github actions"
529+
)
509530
@pytest.mark.integration
510531
@pytest.mark.parametrize(
511532
"sql_registry", [lazy_fixture("mysql_registry"), lazy_fixture("pg_registry")],

0 commit comments

Comments
 (0)