Skip to content

Commit 648ecde

Browse files
committed
see if fix works
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
1 parent ab0d7fb commit 648ecde

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/pr_integration_tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,6 @@ jobs:
175175
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
176176
env:
177177
FEAST_SERVER_DOCKER_IMAGE_TAG: ${{ needs.build-docker-image.outputs.DOCKER_IMAGE_TAG }}
178-
FEAST_USAGE: "False"
179-
IS_TEST: "True"
180178
SNOWFLAKE_CI_DEPLOYMENT: ${{ secrets.SNOWFLAKE_CI_DEPLOYMENT }}
181179
SNOWFLAKE_CI_USER: ${{ secrets.SNOWFLAKE_CI_USER }}
182180
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}

.github/workflows/unit_tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,12 @@ jobs:
7070
run: make install-python-ci-dependencies
7171
- name: Test Python
7272
env:
73-
IS_TEST: "True"
7473
SNOWFLAKE_CI_DEPLOYMENT: ${{ secrets.SNOWFLAKE_CI_DEPLOYMENT }}
7574
SNOWFLAKE_CI_USER: ${{ secrets.SNOWFLAKE_CI_USER }}
7675
SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
7776
SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
7877
SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
79-
run: FEAST_USAGE=False pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests
78+
run: pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests
8079
- name: Upload coverage to Codecov
8180
uses: codecov/codecov-action@v1
8281
with:

sdk/python/tests/conftest.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from multiprocessing import Process
2020
from sys import platform
2121
from typing import Any, Dict, List
22+
import os
2223

2324
import pandas as pd
2425
import pytest
@@ -217,6 +218,8 @@ def pytest_generate_tests(metafunc: pytest.Metafunc):
217218
In order for pytest to group tests together (and share environment fixture)
218219
parameter should point to the same Python object (hence, we use _config_cache dict to store those objects).
219220
"""
221+
os.environ["FEAST_USAGE"] = "False"
222+
os.environ["IS_TEST"] = "True"
220223
if "environment" in metafunc.fixturenames:
221224
markers = {m.name: m for m in metafunc.definition.own_markers}
222225
offline_stores = None

0 commit comments

Comments
 (0)