fix linting

hao-xu5 · hao-xu5 · commit 63bba8791e2e · 2025-11-05T14:34:25.000-08:00
Signed-off-by: hao-xu5 &lt;hxu44@apple.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py b/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
@@ -1,4 +1,3 @@
-import json
 import logging
 import traceback
 import warnings
diff --git a/sdk/python/feast/table_format.py b/sdk/python/feast/table_format.py
@@ -15,7 +15,7 @@
 import json
 from abc import ABC, abstractmethod
 from enum import Enum
-from typing import Dict, Optional, TYPE_CHECKING
+from typing import TYPE_CHECKING, Dict, Optional
 
 if TYPE_CHECKING:
     from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
@@ -171,7 +171,9 @@ def from_dict(cls, data: Dict) -> "IcebergFormat":
 
     def to_proto(self) -> "TableFormatProto":
         """Convert to protobuf TableFormat message"""
-        from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
+        from feast.protos.feast.core.DataFormat_pb2 import (
+            TableFormat as TableFormatProto,
+        )
 
         iceberg_proto = TableFormatProto.IcebergFormat(
             catalog=self.catalog or "",
@@ -268,7 +270,9 @@ def from_dict(cls, data: Dict) -> "DeltaFormat":
 
     def to_proto(self) -> "TableFormatProto":
         """Convert to protobuf TableFormat message"""
-        from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
+        from feast.protos.feast.core.DataFormat_pb2 import (
+            TableFormat as TableFormatProto,
+        )
 
         delta_proto = TableFormatProto.DeltaFormat(
             checkpoint_location=self.checkpoint_location or "",
@@ -281,7 +285,9 @@ def from_proto(cls, proto: "TableFormatProto") -> "DeltaFormat":
         """Create from protobuf TableFormat message"""
         delta_proto = proto.delta_format
         return cls(
-            checkpoint_location=delta_proto.checkpoint_location if delta_proto.checkpoint_location else None,
+            checkpoint_location=delta_proto.checkpoint_location
+            if delta_proto.checkpoint_location
+            else None,
             properties=dict(delta_proto.properties),
         )
 
@@ -390,7 +396,9 @@ def from_dict(cls, data: Dict) -> "HudiFormat":
 
     def to_proto(self) -> "TableFormatProto":
         """Convert to protobuf TableFormat message"""
-        from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
+        from feast.protos.feast.core.DataFormat_pb2 import (
+            TableFormat as TableFormatProto,
+        )
 
         hudi_proto = TableFormatProto.HudiFormat(
             table_type=self.table_type or "",
@@ -407,7 +415,9 @@ def from_proto(cls, proto: "TableFormatProto") -> "HudiFormat":
         return cls(
             table_type=hudi_proto.table_type if hudi_proto.table_type else None,
             record_key=hudi_proto.record_key if hudi_proto.record_key else None,
-            precombine_field=hudi_proto.precombine_field if hudi_proto.precombine_field else None,
+            precombine_field=hudi_proto.precombine_field
+            if hudi_proto.precombine_field
+            else None,
             properties=dict(hudi_proto.properties),
         )
 
@@ -541,7 +551,6 @@ def table_format_from_proto(proto: "TableFormatProto") -> TableFormat:
     Raises:
         ValueError: If the proto doesn't contain a recognized format.
     """
-    from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
 
     which_format = proto.WhichOneof("format")
 
diff --git a/sdk/python/tests/unit/infra/offline_stores/contrib/spark_offline_store/test_spark_table_format_integration.py b/sdk/python/tests/unit/infra/offline_stores/contrib/spark_offline_store/test_spark_table_format_integration.py
@@ -6,7 +6,6 @@
     SparkOptions,
     SparkSource,
 )
-from feast.protos.feast.core.DataFormat_pb2 import TableFormat as TableFormatProto
 from feast.table_format import (
     DeltaFormat,
     HudiFormat,
@@ -235,7 +234,9 @@ def test_spark_options_protobuf_serialization_with_table_format(self):
         assert proto.table_format.HasField("iceberg_format")
         assert proto.table_format.iceberg_format.catalog == "test_catalog"
         assert proto.table_format.iceberg_format.namespace == "test_namespace"
-        assert proto.table_format.iceberg_format.properties["snapshot-id"] == "123456789"
+        assert (
+            proto.table_format.iceberg_format.properties["snapshot-id"] == "123456789"
+        )
 
         # Test deserialization from proto
         restored_options = SparkOptions.from_proto(proto)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import json`
`2`	`1`	`import logging`
`3`	`2`	`import traceback`
`4`	`3`	`import warnings`