chore: Test FeatureView apply to expose entity_columns behavior pre and post apply() (#4571)

franciscojavierarceo · web-flow · commit 626c94f755fa · 2024-09-24T23:29:12.000-04:00
* chore: Adding docs, community, and examples to ignore during PR tests

Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;

* chore: Updating test to confirm feature view apply behavior for entity columns

Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;

* removing changes from other PR

Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;

---------

Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -2,10 +2,6 @@ name: pr-integration-tests
 
 on:
   pull_request_target:
-    paths-ignore:
-      - 'community/**'
-      - 'docs/**'
-      - 'examples/**'
     types:
       - opened
       - synchronize
@@ -100,4 +96,4 @@ jobs:
           SNOWFLAKE_CI_PASSWORD: ${{ secrets.SNOWFLAKE_CI_PASSWORD }}
           SNOWFLAKE_CI_ROLE: ${{ secrets.SNOWFLAKE_CI_ROLE }}
           SNOWFLAKE_CI_WAREHOUSE: ${{ secrets.SNOWFLAKE_CI_WAREHOUSE }}
-        run: make test-python-integration
+        run: make test-python-integration
diff --git a/.github/workflows/pr_local_integration_tests.yml b/.github/workflows/pr_local_integration_tests.yml
@@ -3,14 +3,11 @@ name: pr-local-integration-tests
 
 on:
   pull_request_target:
-    paths-ignore:
-      - 'community/**'
-      - 'docs/**'
-      - 'examples/**'
     types:
       - opened
       - synchronize
       - labeled
+
 jobs:
   integration-test-python-local:
     # when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
diff --git a/sdk/python/tests/unit/test_on_demand_python_transformation.py b/sdk/python/tests/unit/test_on_demand_python_transformation.py
@@ -307,6 +307,8 @@ def setUp(self):
                 online=True,
                 source=driver_stats_source,
             )
+            assert driver_stats_fv.entities == [driver.name]
+            assert driver_stats_fv.entity_columns == []
 
             request_source = RequestSource(
                 name="request_source",
@@ -373,6 +375,11 @@ def python_view(inputs: dict[str, Any]) -> dict[str, Any]:
                 feature_view_name="driver_hourly_stats", df=driver_df
             )
 
+            fv_applied = self.store.get_feature_view("driver_hourly_stats")
+            assert fv_applied.entities == [driver.name]
+            # Note here that after apply() is called, the entity_columns are populated with the join_key
+            assert fv_applied.entity_columns[0].name == driver.join_key
+
     def test_python_transformation_returning_all_data_types(self):
         entity_rows = [
             {

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,8 @@ def setUp(self):`
`307`	`307`	`online=True,`
`308`	`308`	`source=driver_stats_source,`
`309`	`309`	`)`
	`310`	`+ assert driver_stats_fv.entities == [driver.name]`
	`311`	`+ assert driver_stats_fv.entity_columns == []`
`310`	`312`
`311`	`313`	`request_source = RequestSource(`
`312`	`314`	`name="request_source",`
`@@ -373,6 +375,11 @@ def python_view(inputs: dict[str, Any]) -> dict[str, Any]:`
`373`	`375`	`feature_view_name="driver_hourly_stats", df=driver_df`
`374`	`376`	`)`
`375`	`377`
	`378`	`+ fv_applied = self.store.get_feature_view("driver_hourly_stats")`
	`379`	`+ assert fv_applied.entities == [driver.name]`
	`380`	`+ # Note here that after apply() is called, the entity_columns are populated with the join_key`
	`381`	`+ assert fv_applied.entity_columns[0].name == driver.join_key`
	`382`	`+`
`376`	`383`	`def test_python_transformation_returning_all_data_types(self):`
`377`	`384`	`entity_rows = [`
`378`	`385`	`{`