Skip to content

Commit 6084fb9

Browse files
Incorporating the code review comments from Francisco.
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
1 parent f9aea9a commit 6084fb9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

docs/how-to-guides/starting-feast-servers-tls-mode.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,5 +192,5 @@ INFO: Uvicorn running on https://0.0.0.0:8888 (Press CTRL+C to quit)
192192

193193

194194
## Adding public key to CA trust store and configuring the feast to use the trust store.
195-
You can pass the public key for SSL verification using `cert` parameter, however, it is sometimes a hassle to maintain individual certificate and pass the public certificate individually.
196-
The alternate recommendation is to add the public certificate to CA trust store and set the path as environment variable `FEAST_CA_CERT_FILE_PATH`. Feast will refer the trust store path set as environment variable as `FEAST_CA_CERT_FILE_PATH`
195+
You can pass the public key for SSL verification using the `cert` parameter, however, it is sometimes difficult to maintain individual certificates and pass them individually.
196+
The alternative recommendation is to add the public certificate to CA trust store and set the path as an environment variable (e.g., `FEAST_CA_CERT_FILE_PATH`). Feast will use the trust store path in the `FEAST_CA_CERT_FILE_PATH` environment variable.

sdk/python/feast/infra/registry/remote.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,9 @@ class RemoteRegistryConfig(RegistryConfig):
6161
If registry_type is 'remote', then this configuration is needed to connect to remote registry server in TLS mode. If the remote registry started in non-tls mode then this configuration is not needed."""
6262

6363
is_tls: bool = False
64-
""" bool: if you are planning to connect the registry server which started in TLS(SSL) mode then this should be true.
65-
If you are planning to add the public certificate as part of the trust store instead of passing it as a `cert` parameters then setting this field to `true` is a mandatory.
64+
""" bool: Set to `True` if you plan to connect to a registry server running in TLS (SSL) mode.
65+
If you intend to add the public certificate to the trust store instead of passing it via the `cert` parameter, this field must be set to `True`.
66+
If you are planning to add the public certificate as part of the trust store instead of passing it as a `cert` parameters then setting this field to `true` is mandatory.
6667
"""
6768

6869

sdk/python/feast/ssl_ca_trust_store_setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
def configure_ca_trust_store_env_variables():
99
"""
10-
configures the environment variable so that other libraries or servers refer the TLS ca file path.
10+
configures the environment variable so that other libraries or servers refer to the TLS ca file path.
1111
:param ca_file_path:
1212
:return:
1313
"""

0 commit comments

Comments
 (0)