sql

tchughesiv · tchughesiv · commit 5d1b4fefc0ec · 2024-06-14T15:48:18.000-05:00
Signed-off-by: Tommy Hughes &lt;tohughes@redhat.com&gt;
diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
@@ -829,15 +829,13 @@ def _list_objects(
             stmt = select(table).where(table.c.project_id == project)
             rows = conn.execute(stmt).all()
             if rows:
-                objects = [
-                    python_class.from_proto(
+                objects = []
+                for row in rows:
+                    obj = python_class.from_proto(
                         proto_class.FromString(row._mapping[proto_field_name])
                     )
-                    for row in rows
-                ]
-                for obj in objects:
-                    if not utils.has_all_tags(obj.tags, tags):
-                        objects.remove(obj)
+                    if utils.has_all_tags(obj.tags, tags):
+                        objects.append(obj)
                 return objects
         return []
 
