Skip to content

Commit 5c987b3

Browse files
committed
fix: Feast create empty online table when FeatureView attribute online=False
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
1 parent 9ca1452 commit 5c987b3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sdk/python/feast/infra/passthrough_provider.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,12 @@ def update_infra(
148148
):
149149
# Call update only if there is an online store
150150
if self.online_store:
151+
tables_to_keep_online = [fv for fv in tables_to_keep if not isinstance(fv, FeatureView) or fv.online]
152+
151153
self.online_store.update(
152154
config=self.repo_config,
153155
tables_to_delete=tables_to_delete,
154-
tables_to_keep=tables_to_keep,
156+
tables_to_keep=tables_to_keep_online,
155157
entities_to_keep=entities_to_keep,
156158
entities_to_delete=entities_to_delete,
157159
partial=partial,

0 commit comments

Comments
 (0)