fix: Fix mypy type error in nested collection proto construction

soooojinlee · claude · soooojinlee · commit 58dff4146842 · 2026-03-19T23:21:14.000+09:00
Use getattr/CopyFrom instead of **dict unpacking for ProtoValue
construction to satisfy mypy's strict type checking.

Signed-off-by: soojin &lt;soojin@dable.io&gt;
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
Signed-off-by: soojin &lt;soojin@dable.io&gt;
diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -1031,7 +1031,8 @@ def _convert_nested_collection_to_proto(
                         )
                         inner_values.append(proto_vals[0])
             repeated = RepeatedValue(val=inner_values)
-            proto = ProtoValue(**{val_attr: repeated})
+            proto = ProtoValue()
+            getattr(proto, val_attr).CopyFrom(repeated)
             result.append(proto)
     return result
 

Original file line number	Diff line number	Diff line change
`@@ -1031,7 +1031,8 @@ def _convert_nested_collection_to_proto(`
`1031`	`1031`	`)`
`1032`	`1032`	`inner_values.append(proto_vals[0])`
`1033`	`1033`	`repeated = RepeatedValue(val=inner_values)`
`1034`		`- proto = ProtoValue(**{val_attr: repeated})`
	`1034`	`+ proto = ProtoValue()`
	`1035`	`+ getattr(proto, val_attr).CopyFrom(repeated)`
`1035`	`1036`	`result.append(proto)`
`1036`	`1037`	`return result`
`1037`	`1038`