Skip to content

Commit 56e790e

Browse files
committed
chore: update test case due to change of param
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
1 parent 69a8091 commit 56e790e

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

sdk/python/feast/infra/offline_stores/offline_store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def on_demand_feature_views(self) -> List[OnDemandFeatureView]:
192192
def persist(
193193
self,
194194
storage: SavedDatasetStorage,
195-
allow_overwrite: Optional[bool] = False,
195+
allow_overwrite: bool = False,
196196
timeout: Optional[int] = None,
197197
):
198198
"""

sdk/python/tests/unit/infra/offline_stores/test_offline_store.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ def on_demand_feature_views(self) -> List[OnDemandFeatureView]:
6767
"""Returns a list containing all the on demand feature views to be handled."""
6868
pass
6969

70-
def persist(self, storage: SavedDatasetStorage, allow_overwrite: bool = False):
70+
def persist(
71+
self,
72+
storage: SavedDatasetStorage,
73+
allow_overwrite: bool = False,
74+
timeout: Optional[int] = None,
75+
):
7176
"""
7277
Synchronously executes the underlying query and persists the result in the same offline store
7378
at the specified destination.

0 commit comments

Comments
 (0)