Remove grpc keyword where not necessary

Tsotne Tabidze · Tsotne Tabidze · commit 54c3da8434d2 · 2022-05-16T11:37:16.000-07:00
Signed-off-by: Tsotne Tabidze &lt;tsotne@tecton.ai&gt;
diff --git a/go/embedded/online_features.go b/go/embedded/online_features.go
@@ -29,8 +29,8 @@ import (
 )
 
 type OnlineFeatureService struct {
-	fs         *feast.FeatureStore
-	grpcStopCh chan os.Signal
+	fs           *feast.FeatureStore
+	serverStopCh chan os.Signal
 }
 
 type OnlineFeatureServiceConfig struct {
@@ -67,7 +67,7 @@ func NewOnlineFeatureService(conf *OnlineFeatureServiceConfig, transformationCal
 	c := make(chan os.Signal, 1)
 	signal.Notify(c, syscall.SIGINT, syscall.SIGTERM)
 
-	return &OnlineFeatureService{fs: fs, grpcStopCh: c}
+	return &OnlineFeatureService{fs: fs, serverStopCh: c}
 }
 
 func (s *OnlineFeatureService) GetEntityTypesMap(featureRefs []string) (map[string]int32, error) {
@@ -279,7 +279,7 @@ func (s *OnlineFeatureService) StartGprcServerWithLogging(host string, port int,
 
 	go func() {
 		// As soon as these signals are received from OS, try to gracefully stop the gRPC server
-		<-s.grpcStopCh
+		<-s.serverStopCh
 		fmt.Println("Stopping the gRPC server...")
 		grpcServer.GracefulStop()
 		if loggingService != nil {
@@ -324,7 +324,7 @@ func (s *OnlineFeatureService) StartHttpServerWithLogging(host string, port int,
 
 	go func() {
 		// As soon as these signals are received from OS, try to gracefully stop the gRPC server
-		<-s.grpcStopCh
+		<-s.serverStopCh
 		fmt.Println("Stopping the HTTP server...")
 		err := ser.Stop()
 		if err != nil {
@@ -336,7 +336,7 @@ func (s *OnlineFeatureService) StartHttpServerWithLogging(host string, port int,
 }
 
 func (s *OnlineFeatureService) Stop() {
-	s.grpcStopCh <- syscall.SIGINT
+	s.serverStopCh <- syscall.SIGINT
 }
 
 /*
diff --git a/sdk/python/feast/embedded_go/online_features_service.py b/sdk/python/feast/embedded_go/online_features_service.py
@@ -177,10 +177,7 @@ def start_http_server(
         else:
             self._service.StartHttpServer(host, port)
 
-    def stop_http_server(self):
-        self._service.Stop()
-
-    def stop_grpc_server(self):
+    def stop_server(self):
         self._service.Stop()
 
 
diff --git a/sdk/python/tests/integration/e2e/test_go_feature_server.py b/sdk/python/tests/integration/e2e/test_go_feature_server.py
@@ -93,7 +93,7 @@ def grpc_server_port(environment, initialized_registry):
     )
 
     yield port
-    embedded.stop_grpc_server()
+    embedded.stop_server()
     # wait for graceful stop
     time.sleep(2)
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ def grpc_server_port(environment, initialized_registry):`
`93`	`93`	`)`
`94`	`94`
`95`	`95`	`yield port`
`96`		`- embedded.stop_grpc_server()`
	`96`	`+ embedded.stop_server()`
`97`	`97`	`# wait for graceful stop`
`98`	`98`	`time.sleep(2)`
`99`	`99`