fix: Address Devin AI review comments on PR #6202

jyejare · cursoragent · jyejare · commit 541fee2fed88 · 2026-05-28T13:32:16.000+05:30
- Forward set_baseline parameter in DQMJobManager.execute_job for
  compute jobs so user intent to mark a computation as baseline is
  no longer silently dropped.
- Add "1=1" fallback when ts_filter is empty (both start_date and
  end_date are None) in BigQuery, PostgreSQL, and Snowflake monitoring
  compute to prevent invalid SQL generation.

Co-authored-by: Cursor &lt;cursoragent@cursor.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -1101,13 +1101,16 @@ def _bq_compute_monitoring_metrics(
     top_n: int = 10,
 ) -> List[Dict[str, Any]]:
     from_expression = data_source.get_table_query_string()
-    ts_filter = get_timestamp_filter_sql(
-        start_date,
-        end_date,
-        timestamp_field,
-        date_partition_column=data_source.date_partition_column,
-        quote_fields=False,
-        cast_style="timestamp_func",
+    ts_filter = (
+        get_timestamp_filter_sql(
+            start_date,
+            end_date,
+            timestamp_field,
+            date_partition_column=data_source.date_partition_column,
+            quote_fields=False,
+            cast_style="timestamp_func",
+        )
+        or "1=1"
     )
     numeric_features = [n for n, t in feature_columns if t == "numeric"]
     categorical_features = [n for n, t in feature_columns if t == "categorical"]
diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
@@ -315,13 +315,16 @@ def compute_monitoring_metrics(
         assert isinstance(data_source, PostgreSQLSource)
 
         from_expression = data_source.get_table_query_string()
-        ts_filter = get_timestamp_filter_sql(
-            start_date,
-            end_date,
-            timestamp_field,
-            tz=timezone.utc,
-            cast_style="timestamptz",
-            date_time_separator=" ",
+        ts_filter = (
+            get_timestamp_filter_sql(
+                start_date,
+                end_date,
+                timestamp_field,
+                tz=timezone.utc,
+                cast_style="timestamptz",
+                date_time_separator=" ",
+            )
+            or "1=1"
         )
 
         numeric_features = [n for n, t in feature_columns if t == "numeric"]
diff --git a/sdk/python/feast/infra/offline_stores/snowflake.py b/sdk/python/feast/infra/offline_stores/snowflake.py
@@ -451,8 +451,11 @@ def compute_monitoring_metrics(
         from_expression = _qualify_snowflake_from_expression(
             config, data_source, from_expression
         )
-        ts_filter = get_timestamp_filter_sql(
-            start_date, end_date, timestamp_field, tz=timezone.utc
+        ts_filter = (
+            get_timestamp_filter_sql(
+                start_date, end_date, timestamp_field, tz=timezone.utc
+            )
+            or "1=1"
         )
 
         numeric_features = [n for n, t in feature_columns if t == "numeric"]
diff --git a/sdk/python/feast/monitoring/dqm_job_manager.py b/sdk/python/feast/monitoring/dqm_job_manager.py
@@ -136,6 +136,7 @@ def execute_job(self, job_id: str, monitoring_service) -> Dict[str, Any]:
                     if params.get("end_date")
                     else None,
                     granularity=params.get("granularity", "daily"),
+                    set_baseline=params.get("set_baseline", False),
                 )
             else:
                 raise ValueError(f"Unknown job type '{job_type}'")

Original file line number	Diff line number	Diff line change
`@@ -451,8 +451,11 @@ def compute_monitoring_metrics(`
`451`	`451`	`from_expression = _qualify_snowflake_from_expression(`
`452`	`452`	`config, data_source, from_expression`
`453`	`453`	`)`
`454`		`- ts_filter = get_timestamp_filter_sql(`
`455`		`- start_date, end_date, timestamp_field, tz=timezone.utc`
	`454`	`+ ts_filter = (`
	`455`	`+ get_timestamp_filter_sql(`
	`456`	`+ start_date, end_date, timestamp_field, tz=timezone.utc`
	`457`	`+ )`
	`458`	`+ or "1=1"`
`456`	`459`	`)`
`457`	`460`
`458`	`461`	`numeric_features = [n for n, t in feature_columns if t == "numeric"]`
Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@ def execute_job(self, job_id: str, monitoring_service) -> Dict[str, Any]:`
`136`	`136`	`if params.get("end_date")`
`137`	`137`	`else None,`
`138`	`138`	`granularity=params.get("granularity", "daily"),`
	`139`	`+ set_baseline=params.get("set_baseline", False),`
`139`	`140`	`)`
`140`	`141`	`else:`
`141`	`142`	`raise ValueError(f"Unknown job type '{job_type}'")`