Skip to content

Commit 525ac72

Browse files
soooojinleentkathole
authored andcommitted
fix: Address review feedback
1 parent c9c4078 commit 525ac72

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sdk/python/feast/types.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,10 @@ class Set(ComplexFeastType):
199199
base_type: Union[PrimitiveFeastType, ComplexFeastType]
200200

201201
def __init__(self, base_type: Union[PrimitiveFeastType, ComplexFeastType]):
202-
# Sets do not support MAP as a base type
203-
supported_set_types = [t for t in SUPPORTED_BASE_TYPES if t != Map]
202+
# Sets do not support MAP, UUID, or TimeUuid as base types
203+
supported_set_types = [
204+
t for t in SUPPORTED_BASE_TYPES if t not in (Map, Uuid, TimeUuid)
205+
]
204206
if base_type not in supported_set_types:
205207
raise ValueError(
206208
f"Type {type(base_type)} is currently not supported as a base type for Set."

0 commit comments

Comments
 (0)