checking in progress for now, still have some issues with vector retrieval

franciscojavierarceo · franciscojavierarceo · commit 4fc74de4bc2d · 2025-03-22T20:41:04.000-04:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/infra/online_stores/online_store.py b/sdk/python/feast/infra/online_stores/online_store.py
@@ -184,6 +184,7 @@ def get_online_features(
             full_feature_names=full_feature_names,
             native_entity_values=True,
         )
+        # print(f"\nfeature refs = {feature_refs}")
 
         for table, requested_features in grouped_refs:
             # Get the correct set of entity values with the correct join keys.
@@ -194,6 +195,7 @@ def get_online_features(
             )
 
             entity_key_protos = utils._get_entity_key_protos(table_entity_values)
+            print(f"entity key protos {entity_key_protos}")
 
             # Fetch data for Entities.
             read_rows = self.online_read(
diff --git a/sdk/python/feast/infra/online_stores/sqlite.py b/sdk/python/feast/infra/online_stores/sqlite.py
@@ -176,6 +176,14 @@ def online_write_batch(
                             )  # type: ignore
                         else:
                             val_bin = feast_value_type_to_python_type(val)
+                        print(
+                            f"entity_key_bin = {entity_key_bin} (type: {type(entity_key_bin)})\n"
+                            f"feature_name = {feature_name} (type: {type(feature_name)})\n"
+                            f"value = {val.SerializeToString()} (type: {type(val.SerializeToString())})\n"
+                            f"val_bin = {val_bin} (type: {type(val_bin)})\n"
+                            f"timestamp = {timestamp} (type: {type(timestamp)})\n"
+                            f"created_ts = {created_ts} (type: {type(created_ts)})\n"
+                        )
                         conn.execute(
                             f"""
                             INSERT INTO {table_name} (entity_key, feature_name, value, vector_value, event_ts, created_ts)
diff --git a/sdk/python/tests/unit/online_store/test_online_retrieval.py b/sdk/python/tests/unit/online_store/test_online_retrieval.py
@@ -855,10 +855,10 @@ def test_sqlite_hybrid_search() -> None:
     res_df["title"].tolist() == ["Guardians of the Galaxy", "Sing", "Suicide Squad"]
 
 
-@pytest.mark.skipif(
-    sys.version_info[0:2] != (3, 10),
-    reason="Only works on Python 3.10",
-)
+# @pytest.mark.skipif(
+#     sys.version_info[0:2] != (3, 10),
+#     reason="Only works on Python 3.10",
+# )
 def test_sqlite_get_online_documents_v2() -> None:
     """Test retrieving documents using v2 method with vector similarity search."""
     n = 10

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,7 @@ def get_online_features(`
`184`	`184`	`full_feature_names=full_feature_names,`
`185`	`185`	`native_entity_values=True,`
`186`	`186`	`)`
	`187`	`+ # print(f"\nfeature refs = {feature_refs}")`
`187`	`188`
`188`	`189`	`for table, requested_features in grouped_refs:`
`189`	`190`	`# Get the correct set of entity values with the correct join keys.`
`@@ -194,6 +195,7 @@ def get_online_features(`
`194`	`195`	`)`
`195`	`196`
`196`	`197`	`entity_key_protos = utils._get_entity_key_protos(table_entity_values)`
	`198`	`+ print(f"entity key protos {entity_key_protos}")`
`197`	`199`
`198`	`200`	`# Fetch data for Entities.`
`199`	`201`	`read_rows = self.online_read(`