Skip to content

Commit 489f05f

Browse files
achalsachals
authored
Add a caching step to our github actions (#1919)
* Add a caching step to our github actions Signed-off-by: Achal Shah <achals@gmail.com> * remove container Signed-off-by: Achal Shah <achals@gmail.com> * Cache /opt/hostedtoolcache/Python as well Signed-off-by: Achal Shah <achals@gmail.com> * Dummy change to trigger cache Signed-off-by: Achal Shah <achals@gmail.com> * hostedtoolcache for mac Signed-off-by: Achal Shah <achals@gmail.com> * Dummy change to trigger cache Signed-off-by: Achal Shah <achals@gmail.com> * Dummy change to trigger cache Signed-off-by: Achal Shah <achals@gmail.com>
1 parent f31ea81 commit 489f05f

File tree

6 files changed

+67
-3
lines changed

6 files changed

+67
-3
lines changed

‎.github/workflows/integration_tests.yml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
steps:
3030
- uses: actions/checkout@v2
3131
- name: Setup Python
32+
id: setup-python
3233
uses: actions/setup-python@v2
3334
with:
3435
python-version: ${{ matrix.python-version }}
@@ -49,6 +50,20 @@ jobs:
4950
aws-region: us-west-2
5051
- name: Use AWS CLI
5152
run: aws sts get-caller-identity
53+
- name: Get pip cache dir
54+
id: pip-cache
55+
run: |
56+
echo "::set-output name=dir::$(pip cache dir)"
57+
- name: pip cache
58+
uses: actions/cache@v2
59+
with:
60+
path: |
61+
${{ steps.pip-cache.outputs.dir }}
62+
/opt/hostedtoolcache/Python
63+
/Users/runner/hostedtoolcache/Python
64+
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-${{ hashFiles('**/setup.py') }}
65+
restore-keys: |
66+
${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-
5267
- name: Install dependencies
5368
run: make install-python-ci-dependencies
5469
- name: Test python

‎.github/workflows/linter.yml‎

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,29 @@ on: [push, pull_request]
44

55
jobs:
66
lint-python:
7-
container: python:3.7
87
runs-on: [ubuntu-latest]
98
steps:
109
- uses: actions/checkout@v2
10+
- name: Setup Python
11+
id: setup-python
12+
uses: actions/setup-python@v2
13+
with:
14+
python-version: "3.7"
15+
architecture: x64
16+
- name: Get pip cache dir
17+
id: pip-cache
18+
run: |
19+
echo "::set-output name=dir::$(pip cache dir)"
20+
- name: pip cache
21+
uses: actions/cache@v2
22+
with:
23+
path: |
24+
${{ steps.pip-cache.outputs.dir }}
25+
/opt/hostedtoolcache/Python
26+
/Users/runner/hostedtoolcache/Python
27+
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-${{ hashFiles('**/setup.py') }}
28+
restore-keys: |
29+
${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-
1130
- name: Install dependencies
1231
run: make install-python-ci-dependencies
1332
- name: Lint python

‎.github/workflows/pr_integration_tests.yml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ jobs:
4141
submodules: recursive
4242
- name: Setup Python
4343
uses: actions/setup-python@v2
44+
id: setup-python
4445
with:
4546
python-version: ${{ matrix.python-version }}
4647
architecture: x64
@@ -60,6 +61,20 @@ jobs:
6061
aws-region: us-west-2
6162
- name: Use AWS CLI
6263
run: aws sts get-caller-identity
64+
- name: Get pip cache dir
65+
id: pip-cache
66+
run: |
67+
echo "::set-output name=dir::$(pip cache dir)"
68+
- name: pip cache
69+
uses: actions/cache@v2
70+
with:
71+
path: |
72+
${{ steps.pip-cache.outputs.dir }}
73+
/opt/hostedtoolcache/Python
74+
/Users/runner/hostedtoolcache/Python
75+
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-${{ hashFiles('**/setup.py') }}
76+
restore-keys: |
77+
${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-
6378
- name: Install dependencies
6479
run: make install-python-ci-dependencies
6580
- name: Test python

‎.github/workflows/unit_tests.yml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,25 @@ jobs:
1515
steps:
1616
- uses: actions/checkout@v2
1717
- name: Setup Python
18+
id: setup-python
1819
uses: actions/setup-python@v2
1920
with:
2021
python-version: ${{ matrix.python-version }}
2122
architecture: x64
23+
- name: Get pip cache dir
24+
id: pip-cache
25+
run: |
26+
echo "::set-output name=dir::$(pip cache dir)"
27+
- name: pip cache
28+
uses: actions/cache@v2
29+
with:
30+
path: |
31+
${{ steps.pip-cache.outputs.dir }}
32+
/opt/hostedtoolcache/Python
33+
/Users/runner/hostedtoolcache/Python
34+
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-${{ hashFiles('**/setup.py') }}
35+
restore-keys: |
36+
${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-pip-
2237
- name: Install dependencies
2338
run: make install-python-ci-dependencies
2439
- name: Test Python

‎sdk/python/tests/conftest.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2019 The Feast Authors
1+
# Copyright 2021 The Feast Authors
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.

‎sdk/python/tests/utils/online_read_write_test.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def basic_rw_test(
1111
) -> None:
1212
"""
1313
This is a provider-independent test suite for reading and writing from the online store, to
14-
be used by provider-specific tests.
14+
be used by provider-specific tests.
1515
"""
1616
table = store.get_feature_view(name=view_name)
1717

0 commit comments

Comments
 (0)