Fix Docker Compose Batch Serving (#744)

mrzzy · web-flow · commit 47758e16b980 · 2020-05-27T21:08:06.000+08:00
* Fix issue where external Feast client cannot access docker-compose Kafka

This issue occurs when users attempt to interact with an internal
docker-compose Kafka from a extenral. When Feast Core provides the
Kakfa bootstrap servers, its relative to inside the docker-compose
network, and not resolvable from the outside. This adds an
external alias for the internal Kafka to bootstrap servers
so that external clients work correctly.

* Fix batch serving listening on wrong port and incorrect active-store typo

* Fix extra slash in gcs store url.
diff --git a/infra/docker-compose/.env.sample b/infra/docker-compose/.env.sample
@@ -13,7 +13,6 @@ FEAST_SERVING_IMAGE=gcr.io/kf-feast/feast-serving
 # Feast Serving - Batch (BigQuery)
 FEAST_BATCH_SERVING_CONFIG=batch-serving.yml
 FEAST_BATCH_SERVING_GCP_SERVICE_ACCOUNT_KEY=placeholder.json
-FEAST_BATCH_JOB_STAGING_LOCATION=gs://your-gcs-bucket/staging
 # Feast Serving - Online (Redis)
 FEAST_ONLINE_SERVING_CONFIG=online-serving.yml
 
diff --git a/infra/docker-compose/core/core.yml b/infra/docker-compose/core/core.yml
@@ -11,4 +11,4 @@ feast:
     type: kafka
     options:
       topic: feast-features
-      bootstrapServers: kafka:9092
+      bootstrapServers: "kafka:9092,localhost:9094"
diff --git a/infra/docker-compose/serving/batch-serving.yml b/infra/docker-compose/serving/batch-serving.yml
@@ -1,15 +1,15 @@
 feast:
   core-host: core
-  active-store: batch
+  active-store: historical
   stores:
     - name: historical
       type: BIGQUERY
       # Changes required for batch serving to work
       # Please see https://api.docs.feast.dev/grpc/feast.core.pb.html#Store for configuration options
       config:
-        project_id: my_project
-        dataset_id: my_dataset
-        staging_location: gs://mybucket/myprefix
+        project_id: project
+        dataset_id: dataset
+        staging_location: gs://gcs_bucket/prefix
         initial_retry_delay_seconds: 1
         total_timeout_seconds: 21600
       subscriptions:
@@ -18,3 +18,6 @@ feast:
   job_store:
     redis_host: redis
     redis_port: 6379
+  
+grpc:
+  port: 6567
