Fix issue with numpy datetimes in feast_value_type_to_pandas_type (#2167)

achals · web-flow · commit 46b1a35f599f · 2021-12-27T08:36:50.000-08:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/on_demand_feature_view.py b/sdk/python/feast/on_demand_feature_view.py
@@ -259,7 +259,9 @@ def get_requested_odfvs(feature_refs, project, registry):
         return requested_on_demand_feature_views
 
 
-def on_demand_feature_view(features: List[Feature], inputs: Dict[str, FeatureView]):
+def on_demand_feature_view(
+    features: List[Feature], inputs: Dict[str, Union[FeatureView, RequestDataSource]]
+):
     """
     Declare an on-demand feature view
 
diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -64,7 +64,7 @@ def feast_value_type_to_pandas_type(value_type: ValueType) -> Any:
         ValueType.DOUBLE: "float",
         ValueType.BYTES: "bytes",
         ValueType.BOOL: "bool",
-        ValueType.UNIX_TIMESTAMP: "datetime",
+        ValueType.UNIX_TIMESTAMP: "datetime64[ns]",
     }
     if value_type.name.endswith("_LIST"):
         return "object"
diff --git a/sdk/python/tests/integration/registration/test_inference.py b/sdk/python/tests/integration/registration/test_inference.py
@@ -1,12 +1,15 @@
+import pandas as pd
 import pytest
 
-from feast import Entity, RepoConfig, ValueType
+from feast import Entity, Feature, RepoConfig, ValueType
+from feast.data_source import RequestDataSource
 from feast.errors import RegistryInferenceFailure
 from feast.feature_view import FeatureView
 from feast.inference import (
     update_data_sources_with_inferred_event_timestamp_col,
     update_entities_with_inferred_types_from_feature_views,
 )
+from feast.on_demand_feature_view import on_demand_feature_view
 from tests.utils.data_source_utils import (
     prep_file_source,
     simple_bq_source_using_query_arg,
@@ -81,3 +84,21 @@ def test_update_data_sources_with_inferred_event_timestamp_col(simple_dataset_1)
             update_data_sources_with_inferred_event_timestamp_col(
                 [file_source], RepoConfig(provider="local", project="test")
             )
+
+
+def test_modify_feature_views_success():
+    # Create Feature Views
+    date_request = RequestDataSource(
+        name="date_request", schema={"some_date": ValueType.UNIX_TIMESTAMP}
+    )
+
+    @on_demand_feature_view(
+        inputs={"date_request": date_request},
+        features=[Feature("output", ValueType.UNIX_TIMESTAMP)],
+    )
+    def test_view(features_df: pd.DataFrame) -> pd.DataFrame:
+        data = pd.DataFrame()
+        data["output"] = features_df["some_date"]
+        return data
+
+    test_view.infer_features()

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ def feast_value_type_to_pandas_type(value_type: ValueType) -> Any:`
`64`	`64`	`ValueType.DOUBLE: "float",`
`65`	`65`	`ValueType.BYTES: "bytes",`
`66`	`66`	`ValueType.BOOL: "bool",`
`67`		`- ValueType.UNIX_TIMESTAMP: "datetime",`
	`67`	`+ ValueType.UNIX_TIMESTAMP: "datetime64[ns]",`
`68`	`68`	`}`
`69`	`69`	`if value_type.name.endswith("_LIST"):`
`70`	`70`	`return "object"`