adding test

franciscojavierarceo · franciscojavierarceo · commit 463d8bbec423 · 2024-09-29T22:49:34.000-04:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/sdk/python/feast/infra/passthrough_provider.py b/sdk/python/feast/infra/passthrough_provider.py
@@ -286,6 +286,8 @@ def ingest_df(
                 for entity in feature_view.entity_columns
             }
             rows_to_write = _convert_arrow_to_proto(table, feature_view, join_keys)
+            print(rows_to_write)
+            # List[Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]]
 
             self.online_write_batch(
                 self.repo_config, feature_view, rows_to_write, progress=None
diff --git a/sdk/python/tests/unit/test_on_demand_python_transformation.py b/sdk/python/tests/unit/test_on_demand_python_transformation.py
@@ -561,6 +561,8 @@ def setUp(self):
                 online=True,
                 source=driver_stats_source,
             )
+            assert driver_stats_fv.entities == [driver.name]
+            assert driver_stats_fv.entity_columns == [driver.name]
 
             @on_demand_feature_view(
                 entities=[driver],
@@ -602,6 +604,10 @@ def python_stored_writes_feature_view(
                     python_stored_writes_feature_view,
                 ]
             )
+            applied_fv = self.store.get_feature_view("driver_hourly_stats")
+            assert applied_fv.entities[0] == driver.name
+            assert applied_fv.entity_columns[0].name == driver.name
+
             self.store.write_to_online_store(
                 feature_view_name="driver_hourly_stats", df=driver_df
             )

Original file line number	Diff line number	Diff line change
`@@ -286,6 +286,8 @@ def ingest_df(`
`286`	`286`	`for entity in feature_view.entity_columns`
`287`	`287`	`}`
`288`	`288`	`rows_to_write = _convert_arrow_to_proto(table, feature_view, join_keys)`
	`289`	`+ print(rows_to_write)`
	`290`	`+ # List[Tuple[EntityKeyProto, Dict[str, ValueProto], datetime, Optional[datetime]]]`
`289`	`291`
`290`	`292`	`self.online_write_batch(`
`291`	`293`	`self.repo_config, feature_view, rows_to_write, progress=None`
Original file line number	Diff line number	Diff line change
`@@ -561,6 +561,8 @@ def setUp(self):`
`561`	`561`	`online=True,`
`562`	`562`	`source=driver_stats_source,`
`563`	`563`	`)`
	`564`	`+ assert driver_stats_fv.entities == [driver.name]`
	`565`	`+ assert driver_stats_fv.entity_columns == [driver.name]`
`564`	`566`
`565`	`567`	`@on_demand_feature_view(`
`566`	`568`	`entities=[driver],`
`@@ -602,6 +604,10 @@ def python_stored_writes_feature_view(`
`602`	`604`	`python_stored_writes_feature_view,`
`603`	`605`	`]`
`604`	`606`	`)`
	`607`	`+ applied_fv = self.store.get_feature_view("driver_hourly_stats")`
	`608`	`+ assert applied_fv.entities[0] == driver.name`
	`609`	`+ assert applied_fv.entity_columns[0].name == driver.name`
	`610`	`+`
`605`	`611`	`self.store.write_to_online_store(`
`606`	`612`	`feature_view_name="driver_hourly_stats", df=driver_df`
`607`	`613`	`)`