Skip to content

Commit 44b4e49

Browse files
author
Cody Lin
committed
Fix use get with default
Signed-off-by: Cody Lin <codyl@twitter.com>
1 parent 416fddf commit 44b4e49

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

sdk/python/feast/feature_store.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -844,12 +844,15 @@ def get_online_features(
844844
entity = self._registry.get_entity(
845845
entity_name, self.project, allow_cache=True
846846
)
847-
join_key_substitute = feature_view.projection.join_key_map.get(
848-
entity.join_key, entity.name
849-
)
850847
# User directly uses join_key as the entity reference in the entity_rows for the
851848
# entity mapping case.
852-
entity_name_to_join_key_map[join_key_substitute] = join_key_substitute
849+
entity_name = feature_view.projection.join_key_map.get(
850+
entity.join_key, entity.name
851+
)
852+
join_key = feature_view.projection.join_key_map.get(
853+
entity.join_key, entity.join_key
854+
)
855+
entity_name_to_join_key_map[entity_name] = join_key
853856

854857
needed_request_data_features = self._get_needed_request_data_features(
855858
grouped_odfv_refs

0 commit comments

Comments
 (0)