have things behaving with the enviornment arg

franciscojavierarceo · franciscojavierarceo · commit 3fffae44d40a · 2024-12-18T08:34:50.000-05:00
Signed-off-by: Francisco Javier Arceo &lt;farceo@redhat.com&gt;
diff --git a/Makefile b/Makefile
@@ -358,7 +358,7 @@ test-python-universal-milvus-online:
 		FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.online_stores.milvus_online_store.milvus_repo_configuration \
 		PYTEST_PLUGINS=sdk.python.tests.integration.feature_repos.universal.online_store.milvus \
 		python -m pytest -n 8 --integration \
-		-k "test_retrieve_online_documents" \
+		-k "test_retrieve_online_documents2" \
  			sdk/python/tests --ignore=sdk/python/tests/integration/offline_store/test_dqm_validation.py
 
 test-python-universal-singlestore-online:
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -187,7 +187,6 @@ def online_write_batch(
             for k in PROTO_VALUE_TO_VALUE_TYPE_MAP.keys()
             if k is not None and "list" in k and "string" not in k
         ]
-
         entity_batch_to_insert = []
         for entity_key, values_dict, timestamp, created_ts in data:
             # need to construct the composite primary key also need to handle the fact that entities are a list
diff --git a/sdk/python/tests/conftest.py b/sdk/python/tests/conftest.py
@@ -204,16 +204,18 @@ def environment(request, worker_id):
     e.teardown()
 
 
+
 @pytest.fixture
 def vectordb_environment(request, worker_id):
-    milvus_config = IntegrationTestRepoConfig(
+    db_config = IntegrationTestRepoConfig(
         provider="local",
-        online_store="milvus",
-        online_store_creator=MilvusOnlineStoreCreator,
-        offline_store_creator=FileDataSourceCreator,
+        # online_store="milvus",
+        # online_store_creator=MilvusOnlineStoreCreator,
+        # offline_store_creator=FileDataSourceCreator,
     )
+    print(request)
     e = construct_test_environment(
-        milvus_config,
+        db_config,
         fixture_request=request,
         worker_id=worker_id,
         entity_key_serialization_version=3,
@@ -229,7 +231,6 @@ def vectordb_environment(request, worker_id):
 
     e.teardown()
 
-
 _config_cache: Any = {}
 
 
diff --git a/sdk/python/tests/integration/online_store/test_universal_online.py b/sdk/python/tests/integration/online_store/test_universal_online.py
@@ -858,7 +858,7 @@ def assert_feature_service_entity_mapping_correctness(
 
 @pytest.mark.integration
 @pytest.mark.universal_online_stores(
-    only=["pgvector", "elasticsearch", "qdrant", "milvus"]
+    only=["pgvector", "elasticsearch", "qdrant"]
 )
 def test_retrieve_online_documents(vectordb_environment, fake_document_data):
     fs = vectordb_environment.feature_store
@@ -897,8 +897,9 @@ def test_retrieve_online_documents(vectordb_environment, fake_document_data):
 
 @pytest.mark.integration
 @pytest.mark.universal_online_stores(only=["milvus"])
-def test_retrieve_online_documents2(vectordb_environment, fake_document_data):
-    fs = vectordb_environment.feature_store
+def test_retrieve_online_documents2(environment, fake_document_data):
+    print(environment.online_store)
+    fs = environment.feature_store
     df, data_source = fake_document_data
     item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
     fs.apply([item_embeddings_feature_view, item()])

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,6 @@ def online_write_batch(`
`187`	`187`	`for k in PROTO_VALUE_TO_VALUE_TYPE_MAP.keys()`
`188`	`188`	`if k is not None and "list" in k and "string" not in k`
`189`	`189`	`]`
`190`		`-`
`191`	`190`	`entity_batch_to_insert = []`
`192`	`191`	`for entity_key, values_dict, timestamp, created_ts in data:`
`193`	`192`	`# need to construct the composite primary key also need to handle the fact that entities are a list`