region required

leonid133 · leonid133 · commit 3d1b78c09ec4 · 2021-06-29T00:35:29.000-05:00
Signed-off-by: lblokhin &lt;lenin133@yandex.ru&gt;
diff --git a/sdk/python/feast/infra/online_stores/dynamodb.py b/sdk/python/feast/infra/online_stores/dynamodb.py
@@ -39,7 +39,7 @@ class DynamoDBOnlineStoreConfig(FeastConfigBaseModel):
     type: Literal["dynamodb"] = "dynamodb"
     """Online store type selector"""
 
-    region: Optional[StrictStr] = None
+    region: StrictStr
     """ AWS Region Name """
 
 
diff --git a/sdk/python/tests/test_cli_aws.py b/sdk/python/tests/test_cli_aws.py
@@ -30,6 +30,11 @@ def test_basic() -> None:
             project: {project_id}
             registry: {data_path / "registry.db"}
             provider: aws
+            online_store:
+                type: dynamodb
+                region: us-west-2
+            offline_store:
+                type: file
             """
             )
         )
diff --git a/sdk/python/tests/test_feature_store.py b/sdk/python/tests/test_feature_store.py
@@ -24,6 +24,8 @@
 from feast.feature import Feature
 from feast.feature_store import FeatureStore
 from feast.feature_view import FeatureView
+from feast.infra.offline_stores.file import FileOfflineStoreConfig
+from feast.infra.online_stores.dynamodb import DynamoDBOnlineStoreConfig
 from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
 from feast.protos.feast.types import Value_pb2 as ValueProto
 from feast.repo_config import RepoConfig
@@ -86,6 +88,8 @@ def feature_store_with_s3_registry():
             registry=f"s3://{bucket_name}/registries/{int(time.time() * 1000)}/registry.db",
             project="default",
             provider="aws",
+            online_store=DynamoDBOnlineStoreConfig(region="us-west-2"),
+            offline_store=FileOfflineStoreConfig(),
         )
     )
 
diff --git a/sdk/python/tests/test_offline_online_store_consistency.py b/sdk/python/tests/test_offline_online_store_consistency.py
@@ -17,6 +17,7 @@
 from feast.feature import Feature
 from feast.feature_store import FeatureStore
 from feast.feature_view import FeatureView
+from feast.infra.offline_stores.file import FileOfflineStoreConfig
 from feast.infra.online_stores.datastore import DatastoreOnlineStoreConfig
 from feast.infra.online_stores.dynamodb import DynamoDBOnlineStoreConfig
 from feast.infra.online_stores.redis import RedisOnlineStoreConfig, RedisType
@@ -210,7 +211,8 @@ def prep_dynamodb_fs_and_fv() -> Iterator[Tuple[FeatureStore, FeatureView]]:
                 registry=str(Path(repo_dir_name) / "registry.db"),
                 project=f"test_bq_correctness_{str(uuid.uuid4()).replace('-', '')}",
                 provider="aws",
-                online_store=DynamoDBOnlineStoreConfig(type="dynamodb",),
+                online_store=DynamoDBOnlineStoreConfig(region="us-west-2"),
+                offline_store=FileOfflineStoreConfig(),
             )
             fs = FeatureStore(config=config)
             fs.apply([fv, e])

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,11 @@ def test_basic() -> None:`
`30`	`30`	`project: {project_id}`
`31`	`31`	`registry: {data_path / "registry.db"}`
`32`	`32`	`provider: aws`
	`33`	`+ online_store:`
	`34`	`+ type: dynamodb`
	`35`	`+ region: us-west-2`
	`36`	`+ offline_store:`
	`37`	`+ type: file`
`33`	`38`	`"""`
`34`	`39`	`)`
`35`	`40`	`)`