_should_use_plan only returns true for local and sqlite

nossrannug · nossrannug · commit 33a858f54f44 · 2022-03-01T06:31:01.000Z
Only the SQLite local provider supports _plan and _apply_diffs. Updated
the method to only return true for that setup so that other local
providers don't need to implement these methods right now.

Signed-off-by: Gunnar Sv Sigurbjörnsson &lt;gunnar.sigurbjornsson@gmail.com&gt;
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -392,8 +392,10 @@ def _get_features(
 
     def _should_use_plan(self):
         """Returns True if _plan and _apply_diffs should be used, False otherwise."""
-        # Currently only the local provider supports _plan and _apply_diffs.
-        return self.config.provider == "local"
+        # Currently only the local provider with sqlite online store supports _plan and _apply_diffs.
+        return self.config.provider == "local" and (
+            self.config.online_store and self.config.online_store.type == "sqlite"
+        )
 
     def _validate_all_feature_views(
         self,
