Skip to content

Commit 31d5a98

Browse files
authored
fix: Disable snowflake tests temporarily in CI (#6356)
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
1 parent c102738 commit 31d5a98

3 files changed

Lines changed: 21 additions & 9 deletions

File tree

.secrets.baseline

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,14 +1460,14 @@
14601460
"filename": "sdk/python/tests/universal/feature_repos/repo_configuration.py",
14611461
"hashed_secret": "d90e76ef629fb00c95f4e84fec29fbda111e2392",
14621462
"is_verified": false,
1463-
"line_number": 459
1463+
"line_number": 466
14641464
},
14651465
{
14661466
"type": "Secret Keyword",
14671467
"filename": "sdk/python/tests/universal/feature_repos/repo_configuration.py",
14681468
"hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
14691469
"is_verified": false,
1470-
"line_number": 461
1470+
"line_number": 468
14711471
}
14721472
],
14731473
"sdk/python/tests/universal/feature_repos/universal/data_sources/file.py": [
@@ -1539,5 +1539,5 @@
15391539
}
15401540
]
15411541
},
1542-
"generated_at": "2026-04-30T20:52:53Z"
1542+
"generated_at": "2026-05-01T07:12:24Z"
15431543
}

sdk/python/tests/integration/materialization/test_snowflake.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@
2020
)
2121
from tests.utils.e2e_test_validation import validate_offline_online_store_consistency
2222

23+
pytestmark = pytest.mark.skipif(
24+
not os.getenv("SNOWFLAKE_CI_DEPLOYMENT"),
25+
reason="Snowflake account not configured in CI (SNOWFLAKE_CI_DEPLOYMENT not set)",
26+
)
27+
2328
SNOWFLAKE_ENGINE_CONFIG = {
2429
"type": "snowflake.engine",
2530
"account": os.getenv("SNOWFLAKE_CI_DEPLOYMENT", ""),

sdk/python/tests/universal/feature_repos/repo_configuration.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,29 +120,36 @@
120120
from tests.universal.feature_repos.universal.data_sources.redshift import (
121121
RedshiftDataSourceCreator,
122122
)
123-
from tests.universal.feature_repos.universal.data_sources.snowflake import (
124-
SnowflakeDataSourceCreator,
125-
)
126123

127124
AVAILABLE_OFFLINE_STORES.extend(
128125
[
129126
("gcp", BigQueryDataSourceCreator),
130127
("aws", RedshiftDataSourceCreator),
131-
("aws", SnowflakeDataSourceCreator),
132128
]
133129
)
134130

135131
OFFLINE_STORE_TO_PROVIDER_CONFIG["bigquery"] = ("gcp", BigQueryDataSourceCreator)
136132
OFFLINE_STORE_TO_PROVIDER_CONFIG["redshift"] = ("aws", RedshiftDataSourceCreator)
137-
OFFLINE_STORE_TO_PROVIDER_CONFIG["snowflake"] = ("aws", SnowflakeDataSourceCreator)
138133

139134
AVAILABLE_ONLINE_STORES["redis"] = (REDIS_CONFIG, None)
140135
AVAILABLE_ONLINE_STORES["dynamodb"] = (DYNAMO_CONFIG, None)
141136
AVAILABLE_ONLINE_STORES["datastore"] = ("datastore", None)
142-
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
143137
AVAILABLE_ONLINE_STORES["bigtable"] = (BIGTABLE_CONFIG, None)
144138
AVAILABLE_ONLINE_STORES["milvus"] = (MILVUS_CONFIG, None)
145139

140+
# Snowflake is disabled temporarily
141+
if os.getenv("SNOWFLAKE_CI_DEPLOYMENT"):
142+
from tests.universal.feature_repos.universal.data_sources.snowflake import (
143+
SnowflakeDataSourceCreator,
144+
)
145+
146+
AVAILABLE_OFFLINE_STORES.extend([("aws", SnowflakeDataSourceCreator)])
147+
OFFLINE_STORE_TO_PROVIDER_CONFIG["snowflake"] = (
148+
"aws",
149+
SnowflakeDataSourceCreator,
150+
)
151+
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
152+
146153

147154
full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)
148155
if full_repo_configs_module is not None:

0 commit comments

Comments
 (0)