Skip to content

Commit 2f83b8b

Browse files
committed
chore: Update skip reason
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
1 parent f898881 commit 2f83b8b

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

sdk/python/tests/integration/offline_store/test_feature_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
@pytest.mark.parametrize("pass_as_path", [True, False], ids=lambda v: str(v))
3131
@pytest.mark.skipif(
3232
pd.__version__ < "2.2.0" and pd.__version__ >= "2.0.0",
33-
reason="Requires pandas version 2.2.0 or higher",
33+
reason="Skip test due to pandas issue 55730 for pandas version 2.0.0 - 2.1.0",
3434
# https://github.com/pandas-dev/pandas/issues/55730
3535
)
3636
def test_feature_service_logging(environment, universal_data_sources, pass_as_path):

sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,11 @@ def test_historical_features_with_entities_from_query(
340340

341341
table_from_sql_entities = job_from_sql.to_arrow().to_pandas()
342342
for col in table_from_sql_entities.columns:
343+
# check if col dtype is timezone naive
344+
if pd.api.types.is_datetime64_dtype(table_from_sql_entities[col]):
345+
table_from_sql_entities[col] = table_from_sql_entities[col].dt.tz_localize(
346+
"UTC"
347+
)
343348
expected_df_query[col] = expected_df_query[col].astype(
344349
table_from_sql_entities[col].dtype
345350
)
@@ -515,7 +520,7 @@ def test_historical_features_with_no_ttl(
515520
@pytest.mark.universal_offline_stores
516521
@pytest.mark.skipif(
517522
pd.__version__ < "2.2.0" and pd.__version__ >= "2.0.0",
518-
reason="Requires pandas version 2.2.0 or higher",
523+
reason="Skip test due to pandas issue 55730 for pandas version 2.0.0 - 2.1.0",
519524
# https://github.com/pandas-dev/pandas/issues/55730
520525
)
521526
def test_historical_features_from_bigquery_sources_containing_backfills(environment):

0 commit comments

Comments
 (0)