chore: Increase snowflake-connector-python dependency to 3.7 (#4008)

bushwhackr · web-flow · commit 207693810fe7 · 2024-03-11T09:51:16.000-05:00
* increase snowflake-connector-python to 3.7

Signed-off-by: Chester Ong &lt;chester.ong.ch@gmail.com&gt;

* force_return_table to True

Signed-off-by: Chester Ong &lt;chester.ong.ch@gmail.com&gt;

---------

Signed-off-by: Chester Ong &lt;chester.ong.ch@gmail.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/snowflake.py b/sdk/python/feast/infra/offline_stores/snowflake.py
@@ -470,20 +470,9 @@ def _to_df_internal(self, timeout: Optional[int] = None) -> pd.DataFrame:
         return df
 
     def _to_arrow_internal(self, timeout: Optional[int] = None) -> pyarrow.Table:
-        pa_table = execute_snowflake_statement(
+        return execute_snowflake_statement(
             self.snowflake_conn, self.to_sql()
-        ).fetch_arrow_all(force_return_table=False)
-
-        if pa_table:
-            return pa_table
-        else:
-            empty_result = execute_snowflake_statement(
-                self.snowflake_conn, self.to_sql()
-            )
-
-            return pyarrow.Table.from_pandas(
-                pd.DataFrame(columns=[md.name for md in empty_result.description])
-            )
+        ).fetch_arrow_all(force_return_table=True)
 
     def to_sql(self) -> str:
         """
diff --git a/setup.py b/setup.py
@@ -96,7 +96,7 @@
 BYTEWAX_REQUIRED = ["bytewax==0.15.1", "docker>=5.0.2", "kubernetes<=20.13.0"]
 
 SNOWFLAKE_REQUIRED = [
-    "snowflake-connector-python[pandas]>=3,<4",
+    "snowflake-connector-python[pandas]>=3.7,<4",
 ]
 
 SPARK_REQUIRED = [

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@`
`96`	`96`	`BYTEWAX_REQUIRED = ["bytewax==0.15.1", "docker>=5.0.2", "kubernetes<=20.13.0"]`
`97`	`97`
`98`	`98`	`SNOWFLAKE_REQUIRED = [`
`99`		`- "snowflake-connector-python[pandas]>=3,<4",`
	`99`	`+ "snowflake-connector-python[pandas]>=3.7,<4",`
`100`	`100`	`]`
`101`	`101`
`102`	`102`	`SPARK_REQUIRED = [`