Generic error class

achals · achals · commit 2030e4764fb7 · 2021-06-21T14:45:42.000-07:00
Signed-off-by: Achal Shah &lt;achals@gmail.com&gt;
diff --git a/sdk/python/feast/errors.py b/sdk/python/feast/errors.py
@@ -86,9 +86,9 @@ def __init__(self, online_store_class_name: str):
 
 
 class FeastStoreConfigInvalidName(Exception):
-    def __init__(self, online_store_config_class_name: str, store_type="Online"):
+    def __init__(self, store_config_class_name: str, store_type: str):
         super().__init__(
-            f"Online Store Config Class '{online_store_config_class_name}' "
+            f"Config Class '{store_config_class_name}' "
             f"should end with the string `{store_type}Config`.'"
         )
 
diff --git a/sdk/python/feast/repo_config.py b/sdk/python/feast/repo_config.py
@@ -189,7 +189,7 @@ def get_config_class_from_type(
     module_name: str, config_class_name: str, store_type: str
 ):
     if not config_class_name.endswith(f"{store_type}Config"):
-        raise errors.FeastStoreConfigInvalidName(config_class_name)
+        raise errors.FeastStoreConfigInvalidName(config_class_name, store_type)
 
     # Try importing the module that contains the custom provider
     try:

Original file line number	Diff line number	Diff line change
`@@ -86,9 +86,9 @@ def __init__(self, online_store_class_name: str):`
`86`	`86`
`87`	`87`
`88`	`88`	`class FeastStoreConfigInvalidName(Exception):`
`89`		`- def __init__(self, online_store_config_class_name: str, store_type="Online"):`
	`89`	`+ def __init__(self, store_config_class_name: str, store_type: str):`
`90`	`90`	`super().__init__(`
`91`		`- f"Online Store Config Class '{online_store_config_class_name}' "`
	`91`	`+ f"Config Class '{store_config_class_name}' "`
`92`	`92`	f"should end with the string `{store_type}Config`.'"
`93`	`93`	`)`
`94`	`94`