Add GitHub Action for Linting (#559)

woop · web-flow · commit 1c15f65aecdd · 2020-03-21T22:22:04.000+08:00
* Add linting workflow to project

* Refactor makefile to have java dependency installation and go tests
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -0,0 +1,33 @@
+name: Lint
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  lint-java:
+    container: gcr.io/kf-feast/feast-ci:latest
+    runs-on: [ubuntu-latest]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Lint Java
+        run: make lint-java
+
+  lint-python:
+    container: gcr.io/kf-feast/feast-ci:latest
+    runs-on: [ubuntu-latest]
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Lint Python
+        run: make lint-python
+
+  lint-go:
+    container: gcr.io/kf-feast/feast-ci:latest
+    runs-on: [ubuntu-latest]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Lint Go
+        run: make lint-go
diff --git a/Makefile b/Makefile
@@ -24,20 +24,18 @@ format: format-python format-go format-java
 
 lint: lint-python lint-go lint-java
 
-test: test-python test-java
+test: test-python test-java test-go
 
 protos: compile-protos-go compile-protos-python compile-protos-docs
 
 build: protos build-java build-docker build-html
 
-install-ci-dependencies: install-python-ci-dependencies install-go-ci-dependencies
+install-ci-dependencies: install-python-ci-dependencies install-go-ci-dependencies install-java-ci-dependencies
 
 # Java
 
 install-java-ci-dependencies:
-	cd core; mvn dependency:go-offline
-	cd serving; mvn dependency:go-offline
-	cd ingestion; mvn dependency:go-offline
+	mvn verify clean --fail-never
 
 format-java:
 	mvn spotless:apply
@@ -82,6 +80,9 @@ install-go-ci-dependencies:
 compile-protos-go:
 	@$(foreach dir,$(PROTO_TYPE_SUBDIRS), cd ${ROOT_DIR}/protos; protoc -I/usr/local/include -I. --go_out=plugins=grpc,paths=source_relative:../sdk/go/protos/ feast/$(dir)/*.proto;)
 
+test-go:
+	cd ${ROOT_DIR}/sdk/go; go test ./...
+
 format-go:
 	cd ${ROOT_DIR}/sdk/go; gofmt -s -w *.go
 
@@ -116,8 +117,6 @@ build-serving-docker:
 build-ci-docker:
 	docker build -t $(REGISTRY)/feast-ci:latest -f infra/docker/ci/Dockerfile .
 
-
-
 # Documentation
 
 install-dependencies-proto-docs:
