Skip to content

Commit 1a99376

Browse files
sfc-gh-madkinssfc-gh-madkins
committed
hold
1 parent 0c0d468 commit 1a99376

File tree

2 files changed

+39
-39
lines changed

2 files changed

+39
-39
lines changed

‎sdk/python/feast/infra/registry/proto_registry_utils.py‎

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ def get_feature_service(
2626
) -> FeatureService:
2727
for feature_service_proto in registry_proto.feature_services:
2828
if (
29-
feature_service_proto.spec.project == project
30-
and feature_service_proto.spec.name == name
29+
feature_service_proto.spec.name == name
30+
#and feature_service_proto.spec.project == project
3131
):
3232
return FeatureService.from_proto(feature_service_proto)
3333
raise FeatureServiceNotFoundException(name, project=project)
@@ -39,7 +39,7 @@ def get_feature_view(
3939
for feature_view_proto in registry_proto.feature_views:
4040
if (
4141
feature_view_proto.spec.name == name
42-
and feature_view_proto.spec.project == project
42+
#and feature_view_proto.spec.project == project
4343
):
4444
return FeatureView.from_proto(feature_view_proto)
4545
raise FeatureViewNotFoundException(name, project)
@@ -51,7 +51,7 @@ def get_stream_feature_view(
5151
for feature_view_proto in registry_proto.stream_feature_views:
5252
if (
5353
feature_view_proto.spec.name == name
54-
and feature_view_proto.spec.project == project
54+
#and feature_view_proto.spec.project == project
5555
):
5656
return StreamFeatureView.from_proto(feature_view_proto)
5757
raise FeatureViewNotFoundException(name, project)
@@ -61,7 +61,7 @@ def get_request_feature_view(registry_proto: RegistryProto, name: str, project:
6161
for feature_view_proto in registry_proto.feature_views:
6262
if (
6363
feature_view_proto.spec.name == name
64-
and feature_view_proto.spec.project == project
64+
#and feature_view_proto.spec.project == project
6565
):
6666
return RequestFeatureView.from_proto(feature_view_proto)
6767
raise FeatureViewNotFoundException(name, project)
@@ -72,8 +72,8 @@ def get_on_demand_feature_view(
7272
) -> OnDemandFeatureView:
7373
for on_demand_feature_view in registry_proto.on_demand_feature_views:
7474
if (
75-
on_demand_feature_view.spec.project == project
76-
and on_demand_feature_view.spec.name == name
75+
on_demand_feature_view.spec.name == name
76+
#and on_demand_feature_view.spec.project == project
7777
):
7878
return OnDemandFeatureView.from_proto(on_demand_feature_view)
7979
raise OnDemandFeatureViewNotFoundException(name, project=project)
@@ -83,14 +83,14 @@ def get_data_source(
8383
registry_proto: RegistryProto, name: str, project: str
8484
) -> DataSource:
8585
for data_source in registry_proto.data_sources:
86-
if data_source.project == project and data_source.name == name:
86+
if data_source.name == name:# and data_source.project == project:
8787
return DataSource.from_proto(data_source)
8888
raise DataSourceObjectNotFoundException(name, project=project)
8989

9090

9191
def get_entity(registry_proto: RegistryProto, name: str, project: str) -> Entity:
9292
for entity_proto in registry_proto.entities:
93-
if entity_proto.spec.name == name and entity_proto.spec.project == project:
93+
if entity_proto.spec.name == name:# and entity_proto.spec.project == project:
9494
return Entity.from_proto(entity_proto)
9595
raise EntityNotFoundException(name, project=project)
9696

@@ -99,7 +99,7 @@ def get_saved_dataset(
9999
registry_proto: RegistryProto, name: str, project: str
100100
) -> SavedDataset:
101101
for saved_dataset in registry_proto.saved_datasets:
102-
if saved_dataset.spec.name == name and saved_dataset.spec.project == project:
102+
if saved_dataset.spec.name == name:# and saved_dataset.spec.project == project:
103103
return SavedDataset.from_proto(saved_dataset)
104104
raise SavedDatasetNotFound(name, project=project)
105105

@@ -110,7 +110,7 @@ def get_validation_reference(
110110
for validation_reference in registry_proto.validation_references:
111111
if (
112112
validation_reference.name == name
113-
and validation_reference.project == project
113+
#and validation_reference.project == project
114114
):
115115
return ValidationReference.from_proto(validation_reference)
116116
raise ValidationReferenceNotFound(name, project=project)
@@ -121,8 +121,8 @@ def list_feature_services(
121121
) -> List[FeatureService]:
122122
feature_services = []
123123
for feature_service_proto in registry_proto.feature_services:
124-
if feature_service_proto.spec.project == project:
125-
feature_services.append(FeatureService.from_proto(feature_service_proto))
124+
#if feature_service_proto.spec.project == project:
125+
feature_services.append(FeatureService.from_proto(feature_service_proto))
126126
return feature_services
127127

128128

@@ -131,8 +131,8 @@ def list_feature_views(
131131
) -> List[FeatureView]:
132132
feature_views: List[FeatureView] = []
133133
for feature_view_proto in registry_proto.feature_views:
134-
if feature_view_proto.spec.project == project:
135-
feature_views.append(FeatureView.from_proto(feature_view_proto))
134+
#if feature_view_proto.spec.project == project:
135+
feature_views.append(FeatureView.from_proto(feature_view_proto))
136136
return feature_views
137137

138138

@@ -141,10 +141,10 @@ def list_request_feature_views(
141141
) -> List[RequestFeatureView]:
142142
feature_views: List[RequestFeatureView] = []
143143
for request_feature_view_proto in registry_proto.request_feature_views:
144-
if request_feature_view_proto.spec.project == project:
145-
feature_views.append(
146-
RequestFeatureView.from_proto(request_feature_view_proto)
147-
)
144+
#if request_feature_view_proto.spec.project == project:
145+
feature_views.append(
146+
RequestFeatureView.from_proto(request_feature_view_proto)
147+
)
148148
return feature_views
149149

150150

@@ -153,10 +153,10 @@ def list_stream_feature_views(
153153
) -> List[StreamFeatureView]:
154154
stream_feature_views = []
155155
for stream_feature_view in registry_proto.stream_feature_views:
156-
if stream_feature_view.spec.project == project:
157-
stream_feature_views.append(
158-
StreamFeatureView.from_proto(stream_feature_view)
159-
)
156+
#if stream_feature_view.spec.project == project:
157+
stream_feature_views.append(
158+
StreamFeatureView.from_proto(stream_feature_view)
159+
)
160160
return stream_feature_views
161161

162162

@@ -165,26 +165,26 @@ def list_on_demand_feature_views(
165165
) -> List[OnDemandFeatureView]:
166166
on_demand_feature_views = []
167167
for on_demand_feature_view in registry_proto.on_demand_feature_views:
168-
if on_demand_feature_view.spec.project == project:
169-
on_demand_feature_views.append(
170-
OnDemandFeatureView.from_proto(on_demand_feature_view)
171-
)
168+
#if on_demand_feature_view.spec.project == project:
169+
on_demand_feature_views.append(
170+
OnDemandFeatureView.from_proto(on_demand_feature_view)
171+
)
172172
return on_demand_feature_views
173173

174174

175175
def list_entities(registry_proto: RegistryProto, project: str) -> List[Entity]:
176176
entities = []
177177
for entity_proto in registry_proto.entities:
178-
if entity_proto.spec.project == project:
179-
entities.append(Entity.from_proto(entity_proto))
178+
#if entity_proto.spec.project == project:
179+
entities.append(Entity.from_proto(entity_proto))
180180
return entities
181181

182182

183183
def list_data_sources(registry_proto: RegistryProto, project: str) -> List[DataSource]:
184184
data_sources = []
185185
for data_source_proto in registry_proto.data_sources:
186-
if data_source_proto.project == project:
187-
data_sources.append(DataSource.from_proto(data_source_proto))
186+
#if data_source_proto.project == project:
187+
data_sources.append(DataSource.from_proto(data_source_proto))
188188
return data_sources
189189

190190

@@ -193,8 +193,8 @@ def list_saved_datasets(
193193
) -> List[SavedDataset]:
194194
saved_datasets = []
195195
for saved_dataset in registry_proto.saved_datasets:
196-
if saved_dataset.project == project:
197-
saved_datasets.append(SavedDataset.from_proto(saved_dataset))
196+
#if saved_dataset.project == project:
197+
saved_datasets.append(SavedDataset.from_proto(saved_dataset))
198198
return saved_datasets
199199

200200

@@ -203,10 +203,10 @@ def list_validation_reference(
203203
) -> List[ValidationReference]:
204204
validation_references = []
205205
for validation_reference in registry_proto.validation_references:
206-
if validation_reference.project == project:
207-
validation_references.append(
208-
ValidationReference.from_proto(validation_reference)
209-
)
206+
#if validation_reference.project == project:
207+
validation_references.append(
208+
ValidationReference.from_proto(validation_reference)
209+
)
210210
return validation_references
211211

212212

@@ -216,5 +216,5 @@ def list_project_metadata(
216216
return [
217217
ProjectMetadata.from_proto(project_metadata)
218218
for project_metadata in registry_proto.project_metadata
219-
if project_metadata.project == project
219+
#if project_metadata.project == project
220220
]

‎sdk/python/feast/infra/registry/snowflake.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def __init__(
145145
else 0
146146
)
147147

148-
def refresh(self, project: Optional[str]):
148+
def refresh(self):
149149
self.cached_registry_proto = self.proto()
150150
self.cached_registry_proto_created = datetime.utcnow()
151151

0 commit comments

Comments
 (0)