Skip to content

Commit 1a7e4db

Browse files
Adding documentation and incorporating code review comment.
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
1 parent bdfbb72 commit 1a7e4db

File tree

3 files changed

+26
-9
lines changed

3 files changed

+26
-9
lines changed

docs/reference/online-stores/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,7 @@ Please see [Online Store](../../getting-started/architecture-and-components/onli
6161
{% content-ref url="scylladb.md" %}
6262
[scylladb.md](scylladb.md)
6363
{% endcontent-ref %}
64+
65+
{% content-ref url="remote.md" %}
66+
[remote.md](remote.md)
67+
{% endcontent-ref %}
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Remote online store
2+
3+
## Description
4+
5+
This remote online store will let you interact with remote feature server. At this moment this only supports the read operation. You can use this online store and able retrieve online features `store.get_online_features` from remote feature server.
6+
7+
## Examples
8+
9+
The registry is pointing to registry of remote feature store. If it is not accessible then should be configured to use remote registry.
10+
11+
{% code title="feature_store.yaml" %}
12+
```yaml
13+
project: my-local-project
14+
registry: /remote/data/registry.db
15+
provider: local
16+
online_store:
17+
path: http://localhost:6566
18+
type: remote
19+
entity_key_serialization_version: 2
20+
```
21+
{% endcode %}

sdk/python/feast/infra/online_stores/remote.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,7 @@ def online_read(
8686
for index, feature_name in enumerate(
8787
response_json["metadata"]["feature_names"]
8888
):
89-
if self._check_if_feature_requested(
90-
feature_name, requested_features
91-
):
89+
if feature_name in requested_features:
9290
if (
9391
response_json["results"][index]["statuses"][
9492
feature_value_index
@@ -141,12 +139,6 @@ def _construct_online_read_api_json_request(
141139
)
142140
return req_body
143141

144-
def _check_if_feature_requested(self, feature_name, requested_features):
145-
for requested_feature in requested_features:
146-
if feature_name in requested_feature:
147-
return True
148-
return False
149-
150142
def _get_event_ts(self, response_json) -> datetime:
151143
event_ts = ""
152144
if len(response_json["results"]) > 1:

0 commit comments

Comments
 (0)