test: address PR feedback for worker thread errors and signals

mbm-codes · mbm-codes · commit 18100c92dd27 · 2026-06-03T14:25:03.000+05:30
- Simplify worker thread assertion message to safely print errors list

- Add verification for signal handler registration details

Signed-off-by: MBM &lt;mihir105@gmail.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py b/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_queries.py
@@ -1,3 +1,4 @@
+import signal
 import threading
 from unittest.mock import MagicMock, patch
 
@@ -11,11 +12,16 @@ def test_query_init_in_main_thread_registers_signals():
 
     # Should not raise any exception in main thread
     cursor = MagicMock()
+
     with patch("signal.signal") as mock_signal:
+        query = Query(query_text="SELECT 1", cursor=cursor)
+        assert query.query_text == "SELECT 1"
+
         # Verify signal handlers are registered correctly
-        assert mock_signal.call_count == 2
         mock_signal.assert_any_call(signal.SIGINT, query.cancel)
         mock_signal.assert_any_call(signal.SIGTERM, query.cancel)
+
+        # Expected signal.signal to be called twice for SIGINT and SIGTERM
         assert mock_signal.call_count == 2
 
 
@@ -39,4 +45,4 @@ def create_query():
     thread.start()
     thread.join()
 
-    assert not errors, f"Unexpected ValueError in worker thread: {errors[0]}"
+    assert not errors, f"Unexpected ValueError in worker thread: {errors}"
