name the constant, no magic numbers

robhowley · robhowley · commit 17140a5dbf94 · 2024-10-23T13:30:36.000-04:00
diff --git a/sdk/python/feast/infra/utils/aws_utils.py b/sdk/python/feast/infra/utils/aws_utils.py
@@ -1086,11 +1086,16 @@ class DynamoUnprocessedWriteItems(Exception):
 
 
 async def dynamo_write_items(dynamo_client, table_name: str, items: list[Any]) -> None:
+    DYNAMO_MAX_WRITE_BATCH_SIZE = 25
+
     async def _do_write(items):
         item_iter = iter(items)
         item_batches = []
         while True:
-            item_batch = [item for item in itertools.islice(item_iter, 25)]
+            item_batch = [
+                item
+                for item in itertools.islice(item_iter, DYNAMO_MAX_WRITE_BATCH_SIZE)
+            ]
             if not item_batch:
                 break
 
