Skip to content

Commit 0c9f11b

Browse files
Apply linting fixes to SQLite offline store
Co-Authored-By: Francisco Javier Arceo <arceofrancisco@gmail.com>
1 parent 3f2f4f5 commit 0c9f11b

File tree

1 file changed

+16
-12
lines changed
  • sdk/python/feast/infra/offline_stores

1 file changed

+16
-12
lines changed

sdk/python/feast/infra/offline_stores/sqlite.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import os
21
import sqlite3
32
from datetime import datetime
43
from pathlib import Path
@@ -9,10 +8,8 @@
98
import pyarrow
109
from pydantic import StrictStr
1110

12-
from feast import Entity
1311
from feast.data_source import DataSource
1412
from feast.errors import InvalidEntityType
15-
from feast.feature_logging import LoggingConfig, LoggingSource
1613
from feast.feature_view import DUMMY_ENTITY_ID, DUMMY_ENTITY_VAL, FeatureView
1714
from feast.infra.offline_stores import offline_utils
1815
from feast.infra.offline_stores.offline_store import (
@@ -22,7 +19,6 @@
2219
)
2320
from feast.infra.registry.base_registry import BaseRegistry
2421
from feast.repo_config import FeastConfigBaseModel, RepoConfig
25-
from feast.saved_dataset import SavedDatasetStorage
2622
from feast.utils import _get_requested_feature_views_to_features_dict
2723

2824

@@ -99,7 +95,9 @@ def from_proto(data_source_proto: Any):
9995
Returns:
10096
SqliteSource object
10197
"""
102-
raise NotImplementedError("Conversion from proto not implemented for SQLiteSource")
98+
raise NotImplementedError(
99+
"Conversion from proto not implemented for SQLiteSource"
100+
)
103101

104102
def to_proto(self) -> Any:
105103
"""
@@ -108,7 +106,9 @@ def to_proto(self) -> Any:
108106
Returns:
109107
Proto object
110108
"""
111-
raise NotImplementedError("Conversion to proto not implemented for SQLiteSource")
109+
raise NotImplementedError(
110+
"Conversion to proto not implemented for SQLiteSource"
111+
)
112112

113113
def validate(self, config: RepoConfig):
114114
"""
@@ -429,9 +429,13 @@ def get_historical_features(
429429
query=query,
430430
database_path=database_path,
431431
full_feature_names=full_feature_names,
432-
on_demand_feature_views=list(_get_requested_feature_views_to_features_dict(
433-
feature_refs, feature_views, registry.list_on_demand_feature_views(project)
434-
)[1].keys()),
432+
on_demand_feature_views=list(
433+
_get_requested_feature_views_to_features_dict(
434+
feature_refs,
435+
feature_views,
436+
registry.list_on_demand_feature_views(project),
437+
)[1].keys()
438+
),
435439
metadata=RetrievalMetadata(
436440
features=feature_refs,
437441
keys=list(entity_schema.keys() - {entity_df_event_timestamp_col}),
@@ -489,14 +493,14 @@ def _get_database_path(config: RepoConfig) -> str:
489493
Path to the SQLite database file
490494
"""
491495
assert isinstance(config.offline_store, SqliteOfflineStoreConfig)
492-
496+
493497
store_path = config.offline_store.path or "data/offline.db"
494-
498+
495499
if config.repo_path and not Path(store_path).is_absolute():
496500
db_path = str(config.repo_path / store_path)
497501
else:
498502
db_path = store_path
499-
503+
500504
return str(db_path)
501505

502506

0 commit comments

Comments
 (0)