fix: Clean up version history on delete and use write_engine consistently

franciscojavierarceo · claude · franciscojavierarceo · commit 0c1265592ccc · 2026-03-13T11:17:25.000-04:00
- delete_feature_view now also deletes version history records,
  preventing IntegrityError when re-creating a previously deleted FV
- _get_next_version_number uses write_engine instead of read_engine
  to avoid stale version numbers with read replicas

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
@@ -561,6 +561,13 @@ def delete_feature_view(self, name: str, project: str, commit: bool = True):
             )
         if deleted_count == 0:
             raise FeatureViewNotFoundException(name, project)
+        # Clean up version history for the deleted feature view
+        with self.write_engine.begin() as conn:
+            stmt = delete(feature_view_version_history).where(
+                feature_view_version_history.c.feature_view_name == name,
+                feature_view_version_history.c.project_id == project,
+            )
+            conn.execute(stmt)
 
     def delete_feature_service(self, name: str, project: str, commit: bool = True):
         return self._delete_object(
@@ -992,7 +999,7 @@ def _proto_class_for_type(self, fv_type: str):
             raise ValueError(f"Unknown feature view type: {fv_type}")
 
     def _get_next_version_number(self, name: str, project: str) -> int:
-        with self.read_engine.begin() as conn:
+        with self.write_engine.begin() as conn:
             stmt = select(
                 func.coalesce(
                     func.max(feature_view_version_history.c.version_number) + 1, 0
