Skip to content

Commit 05c8164

Browse files
Merge branch 'master' into enable-model-init
2 parents 0f94a90 + fc1599b commit 05c8164

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

infra/website/src/pages/index.astro

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ features = store.retrieve_online_documents(
114114
<div class="logo-item">
115115
<img src="/images/logos/seatgeek.svg" alt="SeatGeek" class="company-logo">
116116
</div>
117-
<div class="logo-item">
118-
<img src="/images/logos/castai.png" alt="Cast.ai" class="company-logo">
119-
</div>
120117
</div>
121118
</div>
122119
</section>

sdk/python/feast/templates/postgres/feature_repo/feature_store.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ project: my_project
22
provider: local
33
registry:
44
registry_type: sql
5-
path: postgresql://postgres:mysecretpassword@127.0.0.1:55001/feast
5+
path: postgresql://DB_USERNAME:DB_PASSWORD@DB_HOST:DB_PORT/DB_NAME
66
cache_ttl_seconds: 60
77
sqlalchemy_config_kwargs:
88
echo: false

sdk/python/tests/unit/local_feast_tests/test_init.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,17 @@ def test_repo_init_with_underscore_in_project_name() -> None:
6767
)
6868
result = runner.run(["apply"], cwd=repo_dir)
6969
assert result.returncode != 0
70+
71+
72+
def test_postgres_template_registry_path_is_parameterized() -> None:
73+
template_fs_yaml = (
74+
Path(__file__).resolve().parents[3]
75+
/ "feast"
76+
/ "templates"
77+
/ "postgres"
78+
/ "feature_repo"
79+
/ "feature_store.yaml"
80+
)
81+
contents = template_fs_yaml.read_text(encoding="utf-8")
82+
expected = "path: postgresql://DB_USERNAME:DB_PASSWORD@DB_HOST:DB_PORT/DB_NAME"
83+
assert expected in contents

0 commit comments

Comments
 (0)