Skip to content

Commit 0303d04

Browse files
committed
Clean ups
Signed-off-by: Terence <terencelimxp@gmail.com>
1 parent 1b36c45 commit 0303d04

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -324,13 +324,14 @@ private void populateHistogramMetrics(
324324
Metrics.requestEntityCount.labels(project).observe(Double.valueOf(entityRows.size()));
325325
Metrics.requestFeatureCount.labels(project).observe(Double.valueOf(featureReferences.size()));
326326

327-
Set<String> featureTableRefs =
327+
long countDistinctFeatureTables =
328328
featureReferences.stream()
329329
.map(featureReference -> getFeatureTableStringRef(project, featureReference))
330-
.collect(Collectors.toSet());
330+
.distinct()
331+
.count();
331332
Metrics.requestFeatureTableCount
332333
.labels(project)
333-
.observe(Double.valueOf(featureTableRefs.size()));
334+
.observe(Double.valueOf(countDistinctFeatureTables));
334335
}
335336

336337
/**

serving/src/main/java/feast/serving/util/Metrics.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ public class Metrics {
2929
.labelNames("method")
3030
.register();
3131

32-
public static final Counter requestCount =
33-
Counter.build()
34-
.name("request_feature_count")
35-
.subsystem("feast_serving")
36-
.help("number of feature rows requested")
37-
.labelNames("project", "feature_name")
38-
.register();
39-
4032
public static final Histogram requestEntityCount =
4133
Histogram.build()
4234
.buckets(1, 2, 5, 10)

0 commit comments

Comments
 (0)