-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expand file tree
/
Copy pathgrpc_server_test.go
More file actions
285 lines (248 loc) · 9.71 KB
/
grpc_server_test.go
File metadata and controls
285 lines (248 loc) · 9.71 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
package server
import (
"context"
"net"
"os"
"path/filepath"
"reflect"
"runtime"
"testing"
"time"
"github.com/stretchr/testify/require"
"github.com/feast-dev/feast/go/internal/feast/registry"
"github.com/apache/arrow/go/v17/arrow/array"
"github.com/apache/arrow/go/v17/arrow/memory"
"github.com/apache/arrow/go/v17/parquet/file"
"github.com/apache/arrow/go/v17/parquet/pqarrow"
"github.com/stretchr/testify/assert"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
"google.golang.org/grpc/test/bufconn"
"github.com/feast-dev/feast/go/internal/feast"
"github.com/feast-dev/feast/go/internal/feast/server/logging"
"github.com/feast-dev/feast/go/internal/test"
"github.com/feast-dev/feast/go/protos/feast/serving"
"github.com/feast-dev/feast/go/protos/feast/types"
)
// Return absolute path to the test_repo directory regardless of the working directory
func getRepoPath(basePath string) string {
// Get the file path of this source file, regardless of the working directory
if basePath == "" {
_, filename, _, ok := runtime.Caller(0)
if !ok {
panic("couldn't find file path of the test file")
}
return filepath.Join(filename, "..", "..", "feature_repo")
} else {
return filepath.Join(basePath, "feature_repo")
}
}
// Starts a new grpc server, registers the serving service and returns a client.
func getClient(ctx context.Context, offlineStoreType string, basePath string, logPath string) (serving.ServingServiceClient, func()) {
buffer := 1024 * 1024
listener := bufconn.Listen(buffer)
server := grpc.NewServer()
config, err := registry.NewRepoConfigFromFile(getRepoPath(basePath))
if err != nil {
panic(err)
}
fs, err := feast.NewFeatureStore(config, nil)
if err != nil {
panic(err)
}
var logSink logging.LogSink
if logPath != "" {
logSink, err = logging.NewFileLogSink(logPath)
if err != nil {
panic(err)
}
}
loggingService, err := logging.NewLoggingService(fs, logSink, logging.LoggingOptions{
WriteInterval: 10 * time.Millisecond,
FlushInterval: logging.DefaultOptions.FlushInterval,
EmitTimeout: logging.DefaultOptions.EmitTimeout,
ChannelCapacity: logging.DefaultOptions.ChannelCapacity,
})
if err != nil {
panic(err)
}
servingServiceServer := NewGrpcServingServiceServer(fs, loggingService)
serving.RegisterServingServiceServer(server, servingServiceServer)
go func() {
if err := server.Serve(listener); err != nil {
panic(err)
}
}()
conn, _ := grpc.NewClient("passthrough:///bufnet", grpc.WithContextDialer(func(context.Context, string) (net.Conn, error) {
return listener.Dial()
}), grpc.WithTransportCredentials(insecure.NewCredentials()))
closer := func() {
listener.Close()
server.Stop()
}
client := serving.NewServingServiceClient(conn)
return client, closer
}
func TestGetFeastServingInfo(t *testing.T) {
ctx := context.Background()
// Pregenerated using `feast init`.
dir := "../../test/"
err := test.SetupInitializedRepo(dir)
defer test.CleanUpInitializedRepo(dir)
require.Nil(t, err)
client, closer := getClient(ctx, "", dir, "")
defer closer()
response, err := client.GetFeastServingInfo(ctx, &serving.GetFeastServingInfoRequest{})
assert.Nil(t, err)
assert.Equal(t, feastServerVersion, response.Version)
}
func TestGetOnlineFeaturesSqlite(t *testing.T) {
ctx := context.Background()
// Pregenerated using `feast init`.
dir := "../../test/"
err := test.SetupInitializedRepo(dir)
defer test.CleanUpInitializedRepo(dir)
require.Nil(t, err)
client, closer := getClient(ctx, "", dir, "")
defer closer()
entities := make(map[string]*types.RepeatedValue)
entities["driver_id"] = &types.RepeatedValue{
Val: []*types.Value{
{Val: &types.Value_Int64Val{Int64Val: 1001}},
{Val: &types.Value_Int64Val{Int64Val: 1003}},
{Val: &types.Value_Int64Val{Int64Val: 1005}},
},
}
request := &serving.GetOnlineFeaturesRequest{
Kind: &serving.GetOnlineFeaturesRequest_Features{
Features: &serving.FeatureList{
Val: []string{"driver_hourly_stats:conv_rate", "driver_hourly_stats:acc_rate", "driver_hourly_stats:avg_daily_trips"},
},
},
Entities: entities,
}
response, err := client.GetOnlineFeatures(ctx, request)
assert.Nil(t, err)
assert.NotNil(t, response)
expectedEntityValuesResp := []*types.Value{
{Val: &types.Value_Int64Val{Int64Val: 1001}},
{Val: &types.Value_Int64Val{Int64Val: 1003}},
{Val: &types.Value_Int64Val{Int64Val: 1005}},
}
expectedFeatureNamesResp := []string{"driver_id", "conv_rate", "acc_rate", "avg_daily_trips"}
rows, err := test.ReadParquet(filepath.Join(dir, "feature_repo", "driver_stats.parquet"))
assert.Nil(t, err)
entityKeys := map[int64]bool{1001: true, 1003: true, 1005: true}
correctFeatures := test.GetLatestFeatures(rows, entityKeys)
expectedConvRateValues := []*types.Value{}
expectedAccRateValues := []*types.Value{}
expectedAvgDailyTripsValues := []*types.Value{}
for _, key := range []int64{1001, 1003, 1005} {
expectedConvRateValues = append(expectedConvRateValues, &types.Value{Val: &types.Value_FloatVal{FloatVal: correctFeatures[key].ConvRate}})
expectedAccRateValues = append(expectedAccRateValues, &types.Value{Val: &types.Value_FloatVal{FloatVal: correctFeatures[key].AccRate}})
expectedAvgDailyTripsValues = append(expectedAvgDailyTripsValues, &types.Value{Val: &types.Value_Int64Val{Int64Val: int64(correctFeatures[key].AvgDailyTrips)}})
}
// Columnar so get in column format row by row should have column names of all features
assert.Equal(t, len(response.Results), 4)
assert.True(t, reflect.DeepEqual(response.Results[0].Values, expectedEntityValuesResp))
assert.True(t, reflect.DeepEqual(response.Results[1].Values, expectedConvRateValues))
assert.True(t, reflect.DeepEqual(response.Results[2].Values, expectedAccRateValues))
assert.True(t, reflect.DeepEqual(response.Results[3].Values, expectedAvgDailyTripsValues))
assert.True(t, reflect.DeepEqual(response.Metadata.FeatureNames.Val, expectedFeatureNamesResp))
}
func TestGetOnlineFeaturesSqliteWithLogging(t *testing.T) {
ctx := context.Background()
// Pregenerated using `feast init`.
dir := "../../test/"
err := test.SetupInitializedRepo(dir)
defer test.CleanUpInitializedRepo(dir)
require.Nil(t, err)
logPath := t.TempDir()
client, closer := getClient(ctx, "file", dir, logPath)
defer closer()
entities := make(map[string]*types.RepeatedValue)
entities["driver_id"] = &types.RepeatedValue{
Val: []*types.Value{
{Val: &types.Value_Int64Val{Int64Val: 1001}},
{Val: &types.Value_Int64Val{Int64Val: 1003}},
{Val: &types.Value_Int64Val{Int64Val: 1005}},
},
}
request := &serving.GetOnlineFeaturesRequest{
Kind: &serving.GetOnlineFeaturesRequest_FeatureService{
FeatureService: "test_service",
},
Entities: entities,
FullFeatureNames: true,
}
response, err := client.GetOnlineFeatures(ctx, request)
assert.Nil(t, err)
assert.NotNil(t, response)
// Get the featurenames without the entity names that are appended at the front.
featureNames := response.Metadata.FeatureNames.Val[len(request.Entities):]
// Generated expected log rows and values
// TODO(kevjumba): implement for timestamp and status
expectedLogValues, _, _ := GetExpectedLogRows(featureNames, response.Results[len(request.Entities):])
expectedLogValues["driver_id"] = entities["driver_id"]
// Wait for logger to flush.
require.Eventually(t, func() bool {
files, err := os.ReadDir(logPath)
if err != nil || len(files) == 0 {
return false
}
stat, err := os.Stat(filepath.Join(logPath, files[0].Name()))
return err == nil && stat.Size() > 0
}, 1*time.Second, 100*time.Millisecond)
files, err := os.ReadDir(logPath)
assert.Nil(t, err)
logFile := filepath.Join(logPath, files[0].Name())
pf, err := file.OpenParquetFile(logFile, false)
assert.Nil(t, err)
reader, err := pqarrow.NewFileReader(pf, pqarrow.ArrowReadProperties{}, memory.DefaultAllocator)
assert.Nil(t, err)
tbl, err := reader.ReadTable(ctx)
assert.Nil(t, err)
tr := array.NewTableReader(tbl, -1)
defer tbl.Release()
defer tr.Release()
for tr.Next() {
rec := tr.Record()
assert.NotNil(t, rec)
actualValues, err := test.GetProtoFromRecord(rec)
assert.Nil(t, err)
// Need to iterate through and compare because certain actualValues in types.RepeatedValues aren't accurately being compared.
for name, val := range expectedLogValues {
if name == "RequestId" {
// Ensure there are request ids for each entity.
assert.Equal(t, len(val.Val), len(actualValues[name].Val))
} else {
assert.Equal(t, len(val.Val), len(actualValues[name].Val))
for idx, featureVal := range val.Val {
assert.Equal(t, featureVal.Val, actualValues[name].Val[idx].Val)
}
}
}
}
}
// Generate the expected log rows based on the resulting feature vector returned from GetOnlineFeatures.
func GetExpectedLogRows(featureNames []string, results []*serving.GetOnlineFeaturesResponse_FeatureVector) (map[string]*types.RepeatedValue, [][]int32, [][]int64) {
numFeatures := len(featureNames)
numRows := len(results[0].Values)
featureValueLogRows := make(map[string]*types.RepeatedValue)
featureStatusLogRows := make([][]int32, numRows)
eventTimestampLogRows := make([][]int64, numRows)
for idx := 0; idx < len(results); idx++ {
valArray := make([]*types.Value, 0)
for row_idx := 0; row_idx < numRows; row_idx++ {
featureStatusLogRows[row_idx] = make([]int32, numFeatures)
eventTimestampLogRows[row_idx] = make([]int64, numFeatures)
valArray = append(valArray, results[idx].Values[row_idx])
featureStatusLogRows[row_idx][idx] = int32(serving.FieldStatus_PRESENT)
eventTimestampLogRows[row_idx][idx] = results[idx].EventTimestamps[row_idx].AsTime().UnixNano() / int64(time.Millisecond)
}
featureValueLogRows[featureNames[idx]] = &types.RepeatedValue{
Val: valArray,
}
}
return featureValueLogRows, featureStatusLogRows, eventTimestampLogRows
}