Skip to content

Commit c71d1bd

Browse files
adamdotdevinadamdotdevin
authored
revert(app): "STUPID SEXY TIMELINE (anomalyco#16420)" (anomalyco#16745)
1 parent f27ef59 commit c71d1bd

48 files changed

Lines changed: 2280 additions & 5492 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎bun.lock‎

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/app/e2e/actions.ts‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { createSdk, modKey, resolveDirectory, serverUrl } from "./utils"
77
import {
88
dropdownMenuTriggerSelector,
99
dropdownMenuContentSelector,
10-
sessionTimelineHeaderSelector,
1110
projectMenuTriggerSelector,
1211
projectCloseMenuSelector,
1312
projectWorkspacesToggleSelector,
@@ -244,9 +243,7 @@ export async function openSessionMoreMenu(page: Page, sessionID: string) {
244243

245244
const scroller = page.locator(".scroll-view__viewport").first()
246245
await expect(scroller).toBeVisible()
247-
const header = page.locator(sessionTimelineHeaderSelector).first()
248-
await expect(header).toBeVisible({ timeout: 30_000 })
249-
await expect(header.getByRole("heading", { level: 1 }).first()).toBeVisible({ timeout: 30_000 })
246+
await expect(scroller.getByRole("heading", { level: 1 }).first()).toBeVisible({ timeout: 30_000 })
250247

251248
const menu = page
252249
.locator(dropdownMenuContentSelector)
@@ -262,7 +259,7 @@ export async function openSessionMoreMenu(page: Page, sessionID: string) {
262259

263260
if (opened) return menu
264261

265-
const menuTrigger = header.getByRole("button", { name: /more options/i }).first()
262+
const menuTrigger = scroller.getByRole("button", { name: /more options/i }).first()
266263
await expect(menuTrigger).toBeVisible()
267264
await menuTrigger.click()
268265

‎packages/app/e2e/selectors.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ export const dropdownMenuContentSelector = '[data-component="dropdown-menu-conte
5151

5252
export const inlineInputSelector = '[data-component="inline-input"]'
5353

54-
export const sessionTimelineHeaderSelector = "[data-session-title]"
55-
5654
export const sessionItemSelector = (sessionID: string) => `${sidebarNavSelector} [data-session-id="${sessionID}"]`
5755

5856
export const workspaceItemSelector = (slug: string) =>

‎packages/app/e2e/session/session.spec.ts‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
openSharePopover,
88
withSession,
99
} from "../actions"
10-
import { sessionItemSelector, inlineInputSelector, sessionTimelineHeaderSelector } from "../selectors"
10+
import { sessionItemSelector, inlineInputSelector } from "../selectors"
1111

1212
const shareDisabled = process.env.OPENCODE_DISABLE_SHARE === "true" || process.env.OPENCODE_DISABLE_SHARE === "1"
1313

@@ -39,14 +39,12 @@ test("session can be renamed via header menu", async ({ page, sdk, gotoSession }
3939
await withSession(sdk, originalTitle, async (session) => {
4040
await seedMessage(sdk, session.id)
4141
await gotoSession(session.id)
42-
await expect(page.locator(sessionTimelineHeaderSelector).getByRole("heading", { level: 1 }).first()).toHaveText(
43-
originalTitle,
44-
)
42+
await expect(page.getByRole("heading", { level: 1 }).first()).toHaveText(originalTitle)
4543

4644
const menu = await openSessionMoreMenu(page, session.id)
4745
await clickMenuItem(menu, /rename/i)
4846

49-
const input = page.locator(sessionTimelineHeaderSelector).locator(inlineInputSelector).first()
47+
const input = page.locator(".scroll-view__viewport").locator(inlineInputSelector).first()
5048
await expect(input).toBeVisible()
5149
await expect(input).toBeFocused()
5250
await input.fill(renamedTitle)
@@ -63,9 +61,7 @@ test("session can be renamed via header menu", async ({ page, sdk, gotoSession }
6361
)
6462
.toBe(renamedTitle)
6563

66-
await expect(page.locator(sessionTimelineHeaderSelector).getByRole("heading", { level: 1 }).first()).toHaveText(
67-
renamedTitle,
68-
)
64+
await expect(page.getByRole("heading", { level: 1 }).first()).toHaveText(renamedTitle)
6965
})
7066
})
7167

0 commit comments

Comments
 (0)