don't await hydro for /events POST response

mikesurowiec · mikesurowiec · commit bd152312f22c · 2021-04-06T07:41:30.000-07:00
diff --git a/middleware/events.js b/middleware/events.js
@@ -19,43 +19,32 @@ router.post('/', async function postEvents (req, res, next) {
     return res.status(400).json({})
   }
 
-  // Don't depend on Hydro on local development
-  if (isDev && !req.hydro.maySend()) {
-    return res.status(200).json({})
-  }
-
-  try {
-    const hydroRes = await req.hydro.publish(
+  if (req.hydro.maySend()) {
+    // intentionally don't await this async request
+    // so that the http response afterwards is sent immediately
+    req.hydro.publish(
       req.hydro.schemas[fields.type],
       omit(fields, OMIT_FIELDS)
-    )
-
-    if (!hydroRes.ok) {
-      const err = new Error('Hydro request failed')
-      err.status = hydroRes.status
-      err.path = fields.path
-
-      await FailBot.report(err, {
-        path: fields.path,
-        hydroStatus: hydroRes.status,
-        hydroText: await hydroRes.text()
-      })
-
-      throw err
-    }
-
-    if (res.headersSent) {
-      throw new Error('Cannot send http response: Hydro publish succeeded, but took too long.')
-    }
-
-    return res.status(201).json(fields)
-  } catch (err) {
-    if (isDev) console.error(err)
-
-    if (!res.headersSent) {
-      return res.status(502).json({})
-    }
+    ).then(async (hydroRes) => {
+      if (!hydroRes.ok) {
+        const err = new Error('Hydro request failed')
+        err.status = hydroRes.status
+        err.path = fields.path
+
+        await FailBot.report(err, {
+          path: fields.path,
+          hydroStatus: hydroRes.status,
+          hydroText: await hydroRes.text()
+        })
+
+        throw err
+      }
+    }).catch((e) => {
+      if (isDev) console.error(e)
+    });
   }
+
+  return res.status(201).json(fields)
 })
 
 module.exports = router
diff --git a/tests/rendering/events.js b/tests/rendering/events.js
@@ -20,7 +20,7 @@ describe('POST /events', () => {
     csrfToken = $('meta[name="csrf-token"]').attr('content')
     nock('http://example.com')
       .post('/hydro')
-      .reply(200, {})
+      .reply(201, {})
   })
 
   afterEach(() => {
@@ -201,7 +201,7 @@ describe('POST /events', () => {
       }, 400)
     )
 
-    it('should a valid os option', () =>
+    it('should os a valid os option', () =>
       checkEvent({
         ...pageExample,
         context: {
