update webhook response to not return fields, return 200

mikesurowiec · mikesurowiec · commit adb81ce5b5fc · 2021-04-06T11:24:21.000-07:00
diff --git a/middleware/events.js b/middleware/events.js
@@ -44,7 +44,7 @@ router.post('/', async function postEvents (req, res, next) {
     })
   }
 
-  return res.status(201).json(fields)
+  return res.status(200).json({})
 })
 
 module.exports = router
diff --git a/tests/rendering/events.js b/tests/rendering/events.js
@@ -20,7 +20,7 @@ describe('POST /events', () => {
     csrfToken = $('meta[name="csrf-token"]').attr('content')
     nock('http://example.com')
       .post('/hydro')
-      .reply(201, {})
+      .reply(200, {})
   })
 
   afterEach(() => {
@@ -74,7 +74,7 @@ describe('POST /events', () => {
     const pageExample = { ...baseExample, type: 'page' }
 
     it('should record a page event', () =>
-      checkEvent(pageExample, 201)
+      checkEvent(pageExample, 200)
     )
 
     it('should require a type', () =>
@@ -128,7 +128,7 @@ describe('POST /events', () => {
           ...pageExample.context,
           page_event_id: baseExample.context.event_id
         }
-      }, 201)
+      }, 200)
     )
 
     it('should not allow a honeypot token', () =>
@@ -295,7 +295,7 @@ describe('POST /events', () => {
     }
 
     it('should record an exit event', () =>
-      checkEvent(exitExample, 201)
+      checkEvent(exitExample, 200)
     )
 
     it('should exit_render_duration is a positive number', () =>
@@ -330,7 +330,7 @@ describe('POST /events', () => {
     }
 
     it('should send a link event', () =>
-      checkEvent(linkExample, 201)
+      checkEvent(linkExample, 200)
     )
 
     it('link_url is a required uri formatted string', () =>
@@ -347,15 +347,15 @@ describe('POST /events', () => {
     }
 
     it('should record a search event', () =>
-      checkEvent(searchExample, 201)
+      checkEvent(searchExample, 200)
     )
 
     it('search_query is required string', () =>
       checkEvent({ ...searchExample, search_query: undefined }, 400)
     )
 
     it('search_context is optional string', () =>
-      checkEvent({ ...searchExample, search_context: undefined }, 201)
+      checkEvent({ ...searchExample, search_context: undefined }, 200)
     )
   })
 
@@ -367,11 +367,11 @@ describe('POST /events', () => {
     }
 
     it('should record a navigate event', () =>
-      checkEvent(navigateExample, 201)
+      checkEvent(navigateExample, 200)
     )
 
     it('navigate_label is optional string', () =>
-      checkEvent({ ...navigateExample, navigate_label: undefined }, 201)
+      checkEvent({ ...navigateExample, navigate_label: undefined }, 200)
     )
   })
 
@@ -385,7 +385,7 @@ describe('POST /events', () => {
     }
 
     it('should record a survey event', () =>
-      checkEvent(surveyExample, 201)
+      checkEvent(surveyExample, 200)
     )
 
     it('survey_vote is boolean', () =>
@@ -411,7 +411,7 @@ describe('POST /events', () => {
     }
 
     it('should record an experiment event', () =>
-      checkEvent(experimentExample, 201)
+      checkEvent(experimentExample, 200)
     )
 
     it('experiment_name is required string', () =>
@@ -423,7 +423,7 @@ describe('POST /events', () => {
     )
 
     it('experiment_success is optional boolean', () =>
-      checkEvent({ ...experimentExample, experiment_success: undefined }, 201)
+      checkEvent({ ...experimentExample, experiment_success: undefined }, 200)
     )
   })
 
@@ -436,7 +436,7 @@ describe('POST /events', () => {
     }
 
     it('should record an redirect event', () =>
-      checkEvent(redirectExample, 201)
+      checkEvent(redirectExample, 200)
     )
 
     it('redirect_from is required url', () =>
@@ -456,7 +456,7 @@ describe('POST /events', () => {
     }
 
     it('should record an clipboard event', () =>
-      checkEvent(clipboardExample, 201)
+      checkEvent(clipboardExample, 200)
     )
 
     it('clipboard_operation is required copy, paste, cut', () =>
@@ -471,7 +471,7 @@ describe('POST /events', () => {
     }
 
     it('should record a print event', () =>
-      checkEvent(printExample, 201)
+      checkEvent(printExample, 200)
     )
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ router.post('/', async function postEvents (req, res, next) {`
`44`	`44`	`})`
`45`	`45`	`}`
`46`	`46`
`47`		`- return res.status(201).json(fields)`
	`47`	`+ return res.status(200).json({})`
`48`	`48`	`})`
`49`	`49`
`50`	`50`	`module.exports = router`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ describe('POST /events', () => {`
`20`	`20`	`csrfToken = $('meta[name="csrf-token"]').attr('content')`
`21`	`21`	`nock('http://example.com')`
`22`	`22`	`.post('/hydro')`
`23`		`- .reply(201, {})`
	`23`	`+ .reply(200, {})`
`24`	`24`	`})`
`25`	`25`
`26`	`26`	`afterEach(() => {`
`@@ -74,7 +74,7 @@ describe('POST /events', () => {`
`74`	`74`	`const pageExample = { ...baseExample, type: 'page' }`
`75`	`75`
`76`	`76`	`it('should record a page event', () =>`
`77`		`- checkEvent(pageExample, 201)`
	`77`	`+ checkEvent(pageExample, 200)`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`it('should require a type', () =>`
`@@ -128,7 +128,7 @@ describe('POST /events', () => {`
`128`	`128`	`...pageExample.context,`
`129`	`129`	`page_event_id: baseExample.context.event_id`
`130`	`130`	`}`
`131`		`- }, 201)`
	`131`	`+ }, 200)`
`132`	`132`	`)`
`133`	`133`
`134`	`134`	`it('should not allow a honeypot token', () =>`
`@@ -295,7 +295,7 @@ describe('POST /events', () => {`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`it('should record an exit event', () =>`
`298`		`- checkEvent(exitExample, 201)`
	`298`	`+ checkEvent(exitExample, 200)`
`299`	`299`	`)`
`300`	`300`
`301`	`301`	`it('should exit_render_duration is a positive number', () =>`
`@@ -330,7 +330,7 @@ describe('POST /events', () => {`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`it('should send a link event', () =>`
`333`		`- checkEvent(linkExample, 201)`
	`333`	`+ checkEvent(linkExample, 200)`
`334`	`334`	`)`
`335`	`335`
`336`	`336`	`it('link_url is a required uri formatted string', () =>`
`@@ -347,15 +347,15 @@ describe('POST /events', () => {`
`347`	`347`	`}`
`348`	`348`
`349`	`349`	`it('should record a search event', () =>`
`350`		`- checkEvent(searchExample, 201)`
	`350`	`+ checkEvent(searchExample, 200)`
`351`	`351`	`)`
`352`	`352`
`353`	`353`	`it('search_query is required string', () =>`
`354`	`354`	`checkEvent({ ...searchExample, search_query: undefined }, 400)`
`355`	`355`	`)`
`356`	`356`
`357`	`357`	`it('search_context is optional string', () =>`
`358`		`- checkEvent({ ...searchExample, search_context: undefined }, 201)`
	`358`	`+ checkEvent({ ...searchExample, search_context: undefined }, 200)`
`359`	`359`	`)`
`360`	`360`	`})`
`361`	`361`
`@@ -367,11 +367,11 @@ describe('POST /events', () => {`
`367`	`367`	`}`
`368`	`368`
`369`	`369`	`it('should record a navigate event', () =>`
`370`		`- checkEvent(navigateExample, 201)`
	`370`	`+ checkEvent(navigateExample, 200)`
`371`	`371`	`)`
`372`	`372`
`373`	`373`	`it('navigate_label is optional string', () =>`
`374`		`- checkEvent({ ...navigateExample, navigate_label: undefined }, 201)`
	`374`	`+ checkEvent({ ...navigateExample, navigate_label: undefined }, 200)`
`375`	`375`	`)`
`376`	`376`	`})`
`377`	`377`
`@@ -385,7 +385,7 @@ describe('POST /events', () => {`
`385`	`385`	`}`
`386`	`386`
`387`	`387`	`it('should record a survey event', () =>`
`388`		`- checkEvent(surveyExample, 201)`
	`388`	`+ checkEvent(surveyExample, 200)`
`389`	`389`	`)`
`390`	`390`
`391`	`391`	`it('survey_vote is boolean', () =>`
`@@ -411,7 +411,7 @@ describe('POST /events', () => {`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`it('should record an experiment event', () =>`
`414`		`- checkEvent(experimentExample, 201)`
	`414`	`+ checkEvent(experimentExample, 200)`
`415`	`415`	`)`
`416`	`416`
`417`	`417`	`it('experiment_name is required string', () =>`
`@@ -423,7 +423,7 @@ describe('POST /events', () => {`
`423`	`423`	`)`
`424`	`424`
`425`	`425`	`it('experiment_success is optional boolean', () =>`
`426`		`- checkEvent({ ...experimentExample, experiment_success: undefined }, 201)`
	`426`	`+ checkEvent({ ...experimentExample, experiment_success: undefined }, 200)`
`427`	`427`	`)`
`428`	`428`	`})`
`429`	`429`
`@@ -436,7 +436,7 @@ describe('POST /events', () => {`
`436`	`436`	`}`
`437`	`437`
`438`	`438`	`it('should record an redirect event', () =>`
`439`		`- checkEvent(redirectExample, 201)`
	`439`	`+ checkEvent(redirectExample, 200)`
`440`	`440`	`)`
`441`	`441`
`442`	`442`	`it('redirect_from is required url', () =>`
`@@ -456,7 +456,7 @@ describe('POST /events', () => {`
`456`	`456`	`}`
`457`	`457`
`458`	`458`	`it('should record an clipboard event', () =>`
`459`		`- checkEvent(clipboardExample, 201)`
	`459`	`+ checkEvent(clipboardExample, 200)`
`460`	`460`	`)`
`461`	`461`
`462`	`462`	`it('clipboard_operation is required copy, paste, cut', () =>`
`@@ -471,7 +471,7 @@ describe('POST /events', () => {`
`471`	`471`	`}`
`472`	`472`
`473`	`473`	`it('should record a print event', () =>`
`474`		`- checkEvent(printExample, 201)`
	`474`	`+ checkEvent(printExample, 200)`
`475`	`475`	`)`
`476`	`476`	`})`
`477`	`477`	`})`