Use self-hosted runners for docs-internal (github#17442)

chiedo · JamesMGreene · web-flow · commit 852a8cde15e2 · 2021-01-25T08:41:53.000-05:00
Use self hosted runners for docs-internal

Co-authored-by: chiedo &lt;chiedo@users.noreply.github.com&gt;
Co-authored-by: James M. Greene &lt;JamesMGreene@github.com&gt;
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -31,7 +31,9 @@ jobs:
 
   test:
     needs: see_if_should_skip
-    runs-on: ubuntu-latest
+    # Run on self-hosted if the private repo or ubuntu-latest if the public repo
+    # See pull # 17442 in the private repo for context
+    runs-on: ${{ fromJSON('["ubuntu-latest", "self-hosted"]')[github.repository == 'github/docs-internal'] }}
     timeout-minutes: 60
     strategy:
       fail-fast: false
@@ -72,15 +74,15 @@ jobs:
         name: Install dependencies
         run: npm ci
 
-      - name: Clone early access
-        if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' && github.repository == 'github/docs-internal' }}
+      - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' && github.repository == 'github/docs-internal' }}
+        name: Clone early access
         run: npm run heroku-postbuild
         env:
           DOCUBOT_REPO_PAT: ${{ secrets.DOCUBOT_REPO_PAT }}
           GIT_BRANCH: ${{ github.ref }}
 
-      - name: Run build script
-        if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' && github.repository != 'github/docs-internal' }}
+      - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' && github.repository != 'github/docs-internal' }}
+        name: Run build script
         run: npm run build
 
       - if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
diff --git a/script/early-access/clone-for-build.js b/script/early-access/clone-for-build.js
@@ -49,7 +49,8 @@ const earlyAccessRepoName = 'docs-early-access'
 const earlyAccessDirName = 'early-access'
 const earlyAccessFullRepo = `https://${DOCUBOT_REPO_PAT}@github.com/${earlyAccessOwner}/${earlyAccessRepoName}`
 
-const earlyAccessCloningParentDir = os.tmpdir()
+// On our Azure self-hosted runners, os.tmpdir() doesn't work reliably. On Heroku, os.homedir doesn't work reliably.
+const earlyAccessCloningParentDir = process.env.CI ? os.homedir() : os.tmpdir()
 const earlyAccessCloningDir = path.join(earlyAccessCloningParentDir, earlyAccessRepoName)
 
 const destinationDirNames = ['content', 'data', 'assets/images']
