Change order of steps in create-translation-batch-pr.yml (github#23210)

mjacobus · web-flow · commit 601d05e6a48e · 2021-11-30T08:28:38.000-08:00
The new order will use "reset known broken files" as a last step. That
way we can better understand if the previous steps were enough to catch
those errors. The least files are reset in that last step, the better.

Also, the check for broken/mismatched liquid tags is performed after
rendering and parsing check. That helps us to identify how useful the
mismatch check is, if at all.
diff --git a/.github/workflows/create-translation-batch-pr.yml b/.github/workflows/create-translation-batch-pr.yml
@@ -99,19 +99,6 @@ jobs:
 
       - run: npm ci
 
-      - name: Reset files with broken liquid tags
-        run: |
-          node script/i18n/reset-files-with-broken-liquid-tags.js --language=${{ matrix.language_code }}
-          git add translations/${{ matrix.language }} && git commit -m "run script/i18n/reset-files-with-broken-liquid-tags.js --language=${{ matrix.language_code }}" || echo "Nothing to commit"
-
-      # step 5 in docs-engineering/crowdin.md using script from docs-internal#22709
-      - name: Reset known broken files
-        run: |
-          node script/i18n/reset-known-broken-translation-files.js
-          git add translations/${{ matrix.language }} && git commit -m "run script/i18n/reset-known-broken-translation-files.js" || echo "Nothing to commit"
-        env:
-          GITHUB_TOKEN: ${{ secrets.DOCUBOT_REPO_PAT }}
-
       # step 6 in docs-engineering/crowdin.md
       - name: Homogenize frontmatter
         run: |
@@ -127,15 +114,28 @@ jobs:
       # step 8a in docs-engineering/crowdin.md
       - name: Check parsing
         run: |
-          node script/i18n/lint-translation-files.js --check parsing
+          node script/i18n/lint-translation-files.js --check parsing | tee -a /tmp/batch.log | cat
           git add translations/${{ matrix.language }} && git commit -m "Run script/i18n/lint-translation-files.js --check parsing" || echo "Nothing to commit"
 
       # step 8b in docs-engineering/crowdin.md
       - name: Check rendering
         run: |
-          node script/i18n/lint-translation-files.js --check rendering
+          node script/i18n/lint-translation-files.js --check rendering | tee -a /tmp/batch.log | cat
           git add translations/${{ matrix.language }} && git commit -m "Run script/i18n/lint-translation-files.js --check rendering" || echo "Nothing to commit"
 
+      - name: Reset files with broken liquid tags
+        run: |
+          node script/i18n/reset-files-with-broken-liquid-tags.js --language=${{ matrix.language_code }} | tee -a /tmp/batch.log | cat
+          git add translations/${{ matrix.language }} && git commit -m "run script/i18n/reset-files-with-broken-liquid-tags.js --language=${{ matrix.language_code }}" || echo "Nothing to commit"
+
+      # step 5 in docs-engineering/crowdin.md using script from docs-internal#22709
+      - name: Reset known broken files
+        run: |
+          node script/i18n/reset-known-broken-translation-files.js | tee -a /tmp/batch.log | cat
+          git add translations/${{ matrix.language }} && git commit -m "run script/i18n/reset-known-broken-translation-files.js" || echo "Nothing to commit"
+        env:
+          GITHUB_TOKEN: ${{ secrets.DOCUBOT_REPO_PAT }}
+
       - name: Check in CSV report
         run: |
           mkdir -p log
