Skip to content

Commit 3f8f75e

Browse files
committed
YAGNI: Remove support for {% all %}
1 parent b08584e commit 3f8f75e

4 files changed

Lines changed: 6 additions & 14 deletions

File tree

contributing/content-markup-reference.md

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ For information on when to use callout tags, see the [style guide](content-style
3838

3939
To render syntax highlighting in command line instructions, we use triple backticks followed by the term `shell`.
4040

41-
### Usage
42-
43-
```shell
44-
git init <em>YOUR_REPO</em>
41+
### Usage
42+
43+
```shell
44+
git init <em>YOUR_REPO</em>
4545
```
4646

4747
This syntax highlighting renders light text on a dark background, and should be reserved for command line instructions.
@@ -93,13 +93,6 @@ These instructions are pertinent to Windows users.
9393
9494
{% endlinux %}
9595
```
96-
```
97-
{% all %}
98-
99-
Though rare, these instructions are pertinent to any other operating system.
100-
101-
{% endall %}
102-
```
10396

10497
## Reusable and variable strings of text
10598

includes/article.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ <h1 class="border-bottom-0">{{ page.title }}</h1>
3535
<a href="#" class="UnderlineNav-item platform-switcher" data-platform="mac">Mac</a>
3636
<a href="#" class="UnderlineNav-item platform-switcher" data-platform="windows">Windows</a>
3737
<a href="#" class="UnderlineNav-item platform-switcher" data-platform="linux">Linux</a>
38-
<a href="#" class="UnderlineNav-item platform-switcher" data-platform="all">All</a>
3938
</div>
4039
</nav>
4140
{% endif %}

lib/frontmatter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ const schema = {
104104
// Platform-specific content preference
105105
defaultPlatform: {
106106
type: 'string',
107-
enum: ['mac', 'windows', 'linux'] // TODO: add 'all'?
107+
enum: ['mac', 'windows', 'linux']
108108
}
109109
}
110110
}

lib/page.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class Page {
189189
const $ = cheerio.load(html)
190190

191191
// set a flag so layout knows whether to render a mac/windows/linux switcher element
192-
this.includesPlatformSpecificContent = $('[class^="platform-"], .mac, .windows, .linux, .all').length > 0
192+
this.includesPlatformSpecificContent = $('[class^="platform-"], .mac, .windows, .linux').length > 0
193193

194194
// rewrite asset paths to s3 if it's a dotcom article on any GHE version
195195
// or if it's an enterprise article on any GHE version EXCEPT latest version

0 commit comments

Comments
 (0)