Skip to content

Commit 0971f6e

Browse files
committed
put toggle images button down next to scroll button
1 parent 94ec691 commit 0971f6e

File tree

5 files changed

+19
-16
lines changed

5 files changed

+19
-16
lines changed

includes/article.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ <h2 id="in-this-article" class="f5 mb-2"><a class="Link--primary" href="#in-this
6262
</ul>
6363
{% endif %}
6464
</div>
65-
{% include toggle-images %}
6665
</div>
6766
<div id="article-contents" class="article-grid-body">
6867
{% if featuredLinks.gettingStarted and featuredLinks.popular %}

includes/scroll-button.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<button class="arrow-for-scrolling-top" id="js-scroll-top">
2-
{% octicon "chevron-up" %}
2+
<span aria-label="{% data ui.scroll_to_top %}">{% octicon "chevron-up" %}</span>
33
</button>

includes/toggle-images.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<button class="toggle-images tooltipped tooltipped-n" id="js-toggle-images" style="display: none;">
2-
<span id="js-hide-icon" aria-label="{% data ui.toggle_images.hide %}" style="display: none;">{% octicon "eye-closed" %}</span>
3-
<span id="js-show-icon" aria-label="{% data ui.toggle_images.show %}" style="display: none;">{% octicon "eye" %}</span>
1+
<button class="toggle-images tooltipped tooltipped-nw tooltipped-no-delay" id="js-toggle-images" style="display: none;">
2+
<span id="js-off-icon" aria-label="{% data ui.toggle_images.off %}" style="display: none;">{% octicon "eye-closed" %}</span>
3+
<span id="js-on-icon" aria-label="{% data ui.toggle_images.on %}" style="display: none;">{% octicon "eye" %}</span>
44
<span id="js-hide-single-image" aria-label="{% data ui.toggle_images.hide_single %}" style="display: none;"></span>
55
<span id="js-show-single-image" aria-label="{% data ui.toggle_images.show_single %}" style="display: none;"></span>
66
</button>

stylesheets/scroll-button.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ button.arrow-for-scrolling-top {
55
color: var(--color-text-inverse);
66
position: fixed;
77
bottom: 10px;
8-
right: 10px;
8+
// right: 10px;
9+
// padding-right: 50px;
10+
right: 60px;
911
display: block;
1012
width: 40px;
1113
height: 40px;
Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
button.toggle-images {
2-
opacity: 1;
3-
transition: 1s;
4-
background-color: var(--color-auto-blue-5);
5-
color: var(--color-text-inverse);
6-
position: fixed;
7-
display: block;
8-
width: 40px;
9-
height: 40px;
10-
border-radius: 50%;
11-
border: none;
2+
opacity: 1;
3+
transition: 1s;
4+
background-color: var(--color-auto-blue-5);
5+
color: var(--color-text-inverse);
6+
position: fixed;
7+
bottom: 10px;
8+
right: 10px;
9+
display: block;
10+
width: 40px;
11+
height: 40px;
12+
border-radius: 50%;
13+
border: none;
1214
}

0 commit comments

Comments
 (0)